close
Skip to content

unsnap: Add at 2023.03.11#3208

Merged
silkeh merged 1 commit into
mainfrom
add-unsnap
Jul 11, 2024
Merged

unsnap: Add at 2023.03.11#3208
silkeh merged 1 commit into
mainfrom
add-unsnap

Conversation

@silkeh
Copy link
Copy Markdown
Member

@silkeh silkeh commented Jul 3, 2024

Summary

Initial inclusion of unsnap at the last upstream commit. It includes a patchset that adds support for eopkg.

Resolves #323

Test Plan

Run sudo unsnap auto to automatically migrate snaps to flatpak.

Checklist

  • Package was built and tested against unstable

@Staudey
Copy link
Copy Markdown
Member

Staudey commented Jul 3, 2024

Is the patch for the README really necessary, as it doesn't seem to be included in the final package?

@ermo
Copy link
Copy Markdown
Contributor

ermo commented Jul 3, 2024

Works for me per 17ce51d

@silkeh silkeh force-pushed the add-unsnap branch 2 times, most recently from 48a8876 to a267606 Compare July 3, 2024 16:10
@silkeh
Copy link
Copy Markdown
Member Author

silkeh commented Jul 3, 2024

I have included additional patches to improve the user experience. In particular, unsnap now disables all remaining systemd units.

Is the patch for the README really necessary, as it doesn't seem to be included in the final package?

No, but it is part of the patchset I've rebased from an open PR. I'm hoping to upstream it at some point.

@silkeh silkeh marked this pull request as ready for review July 10, 2024 14:27
@silkeh
Copy link
Copy Markdown
Member Author

silkeh commented Jul 10, 2024

I've made sure that it works with the wrapper script from #3211. Should be good to go now!

ermo
ermo previously approved these changes Jul 11, 2024
Copy link
Copy Markdown
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused when just running sudo unsnap, because there is no help output and the script didn't give me a message at the end telling me how to actually effectuate the changes?

Suggestion: Consider making sudo unsnap print out a message telling the user to:

  • check out the help page
  • use sudo unsnap auto to actually remove snaps and snapd

**Summary**

Initial inclusion of `unsnap` at the last upstream commit.
It includes a patchset that adds support for `eopkg` and our snap wrapper.
@silkeh
Copy link
Copy Markdown
Member Author

silkeh commented Jul 11, 2024

@ermo: I added a message with clarification. Let me know what you think!

@silkeh silkeh requested a review from ermo July 11, 2024 21:21
Copy link
Copy Markdown
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@silkeh silkeh merged commit c786d17 into main Jul 11, 2024
@silkeh silkeh deleted the add-unsnap branch July 11, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

unsnap

3 participants