close
Skip to content

snapd: Add confinement warning#3211

Merged
silkeh merged 1 commit into
mainfrom
snap-confinement-warning
Jul 11, 2024
Merged

snapd: Add confinement warning#3211
silkeh merged 1 commit into
mainfrom
snap-confinement-warning

Conversation

@silkeh
Copy link
Copy Markdown
Member

@silkeh silkeh commented Jul 3, 2024

Summary

Add a warning when starting snap applications. The warning is shown on the CLI when invoking snap there, and as a notification when starting a GUI application.

Test Plan

Run a snap command on the CLI:

afbeelding

Run a GUI application:

afbeelding

Checklist

  • Package was built and tested against unstable

@ermo
Copy link
Copy Markdown
Contributor

ermo commented Jul 3, 2024

Looks promising!

@silkeh silkeh force-pushed the snap-confinement-warning branch 2 times, most recently from 8c9631e to 588c64e Compare July 10, 2024 14:21
@silkeh
Copy link
Copy Markdown
Member Author

silkeh commented Jul 10, 2024

I updated the script with two things:

  • A check for strict confinement. This means that no warning will be shown on LTS for the time being.
  • A command-line option to disable the warning.

Updated output:

image

image

I'll PR the help center page later today!

@silkeh silkeh marked this pull request as ready for review July 10, 2024 14:22
@silkeh silkeh mentioned this pull request Jul 10, 2024
1 task
@silkeh silkeh force-pushed the snap-confinement-warning branch from 588c64e to 3ac4488 Compare July 10, 2024 14:38
ermo
ermo previously approved these changes Jul 11, 2024
Copy link
Copy Markdown
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things worked for me as-is.

I have only added a few nits that you may or may not wish to address.

Comment thread packages/s/snapd/files/wrapper.sh
Comment thread packages/s/snapd/files/wrapper.sh Outdated
Comment thread packages/s/snapd/files/wrapper.sh Outdated
**Summary**

Add a warning when starting snap applications. The warning is shown on the CLI when invoking `snap` there, and as a notification when starting a GUI application.
@silkeh silkeh force-pushed the snap-confinement-warning branch from 3ac4488 to 75ebac7 Compare July 11, 2024 19:10
@silkeh silkeh requested a review from ermo July 11, 2024 19:12
Copy link
Copy Markdown
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@silkeh silkeh merged commit 5c35c7e into main Jul 11, 2024
@silkeh silkeh deleted the snap-confinement-warning branch July 11, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants