close
Skip to content

Fix File Provider Item Eviction#9981

Merged
i2h3 merged 2 commits into
masterfrom
i2h3/fix/9891-evict-pinned
May 7, 2026
Merged

Fix File Provider Item Eviction#9981
i2h3 merged 2 commits into
masterfrom
i2h3/fix/9891-evict-pinned

Conversation

@i2h3
Copy link
Copy Markdown
Collaborator

@i2h3 i2h3 commented May 6, 2026 •
edited
Loading

Fixes #9891 and #9757.

  • Suppress Finder's own context menu item to evict file provider items because it collides with the item's content policy of being kept available offline, causing the file provider framework-level bug described in Download cannot be removed for pinned items #9891.
  • Added custom action to evict materialized items.
  • Restrict custom evict action to items not marked to be kept offline because otherwise it will result in the same problem described in Download cannot be removed for pinned items #9891. macOS needs to learn about the updated content policy first. That happens asynchronously and poses a race condition. Hence this two step process ensures the Finder bug is avoided.
  • Reporting the default content policy of .inherit instead of . downloadEagerlyAndKeepDownloaded would sabotage the reliable retention of materialized items. Hence that must be preserved.

@i2h3 i2h3 added this to the 33.0.5 milestone May 6, 2026
@i2h3 i2h3 self-assigned this May 6, 2026
@i2h3 i2h3 added bug os: 🍎 macOS Apple macOS, formerly also known as OS X feature: 📁 file provider macOS File Provider Extension, more general also known as virtual file system. labels May 6, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 💻 Desktop Clients team May 6, 2026
@i2h3
Copy link
Copy Markdown
Collaborator Author

i2h3 commented May 6, 2026

/backport to stable-33.0

@i2h3 i2h3 force-pushed the i2h3/fix/9891-evict-pinned branch 2 times, most recently from 4e6dfde to a94ac34 Compare May 7, 2026 09:55
@i2h3 i2h3 marked this pull request as ready for review May 7, 2026 10:49
@i2h3
fix(file-provider): Surpress Finder's native eviction actions (#9891)
ca2b7af 
Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
@i2h3 i2h3 force-pushed the i2h3/fix/9891-evict-pinned branch from a94ac34 to 521ec88 Compare May 7, 2026 10:49
@i2h3
feat(file-provider): Finished custom evict action.
cc0d9a4 
Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
@i2h3 i2h3 force-pushed the i2h3/fix/9891-evict-pinned branch from 521ec88 to cc0d9a4 Compare May 7, 2026 11:10
@i2h3 i2h3 moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 💻 Desktop Clients team May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Artifact containing the AppImage: nextcloud-appimage-pr-9981.zip

Digest: sha256:976a34a8354d7abc1686ac495e432107b9b61a05fe0b0618334efb8b33e753d2

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@i2h3 i2h3 merged commit 9ac8d75 into master May 7, 2026
20 of 21 checks passed
@github-project-automation github-project-automation Bot moved this from 🏗️ In progress to ☑️ Done in 💻 Desktop Clients team May 7, 2026
@i2h3 i2h3 deleted the i2h3/fix/9891-evict-pinned branch May 7, 2026 12:40
@backportbot backportbot Bot mentioned this pull request May 7, 2026
Merged
3 tasks
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

Quality Gate Passed Quality Gate passed

Issues
BERJAYA 0 New issues
BERJAYA 0 Accepted issues

Measures
BERJAYA 0 Security Hotspots
BERJAYA 0.0% Coverage on New Code
BERJAYA 0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@i2h3 i2h3 mentioned this pull request May 13, 2026
Closed
8 tasks
@fracture-point fracture-point mentioned this pull request May 19, 2026
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner

@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner

@nilsding nilsding Awaiting requested review from nilsding nilsding is a code owner

Assignees

@i2h3 i2h3

Labels

bug feature: 📁 file provider macOS File Provider Extension, more general also known as virtual file system. os: 🍎 macOS Apple macOS, formerly also known as OS X

Projects

None yet

Milestone

33.0.5

Development

Successfully merging this pull request may close these issues.

Download cannot be removed for pinned items

2 participants

@i2h3 @Rello