Tags for actions

[elijahbenizzy]

Is your feature request related to a problem? Please describe.
We should be able to tag actions. In particular, this could be used to do halt_after and halt_before.

Describe the solution you'd like

@action(reads=[...], writes=[...], tags=["requires_human_input"])
def act(state: State, human_input: ...) -> State:
    ...

app.run(halt_before=["requires_human_input"])

Would have to do this at the class-level as well, should be straightforward. Also there's the possibility of name-clashes on halt. I'm OK with that due to the simplicity here.

Could also do this at the action level -- in the builder with_actions(some_action=action.with_tags(["requires_human_input"]). Would have to think about how to do this with function-based actions (TBD).

Describe alternatives you've considered
See above

Additional context
Something I've been mulling over for a while.

[skrawcz]

suggestion to know how to read it better: ***@***.***:requires_human_input"])

…

On Wed, Dec 11, 2024 at 2:57 PM Elijah ben Izzy ***@***.***> wrote: *Is your feature request related to a problem? Please describe.* We should be able to tag actions. In particular, this could be used to do halt_after and halt_before. *Describe the solution you'd like* @action(reads=[...], writes=[...], tags=["requires_human_input"])def act(state: State, human_input: ...) -> State: ... app.run(halt_before=["requires_human_input"]) Would have to do this at the class-level as well, should be straightforward. Also there's the possibility of name-clashes on halt. I'm OK with that due to the simplicity here. Could also do this at the action level -- in the builder with_actions(some_action=action.with_tags(["requires_human_input"]). Would have to think about how to do this with function-based actions (TBD). *Describe alternatives you've considered* See above *Additional context* Something I've been mulling over for a while. — Reply to this email directly, view it on GitHub <#468>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARYMBZV773FDQ7KDL2FSUT2FC7MPAVCNFSM6AAAAABTOQXMN6VHI2DSMVQWIX3LMV43ASLTON2WKOZSG4ZTIMJZGYYTEOI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[elijahbenizzy]

OK, thoughts:

• these are node name aliases
• Stopping before/after any of X,Y,Z is the use-case — this is a common problem I’ve observed where people enumerate out node names, hard-coded. Tags form aliases for multiple nodes. `@action(tags=[“foo”, “bar”]) -> halt_after=["foo", "bar"], mixed freely with ["node_1", "node_2"])
• Will work for class/function-based (although quite a few APIs to cover here) — likely an instance method
  (pending time) Will likely have system-level tags (E.G. __has__input and has_input) for named inputs — the non-dynamically-generated ones will be constants, otherwise it will be a function
  • This specifically solves the problem of pausing before all inputs and all inputs of form X (E.G. multiple need the same)
    -IMO this is key for human in the loop/control flow.
• Tags will have very specific naming structures — python var name, no starting with underscore, no ending with undrescore

[elijahbenizzy]

This is complete! See #505