Editorial: Fix incorrect validation of variants for Intl.Locale construction#1007
Merged
gibson042 merged 1 commit intoMay 30, 2025
Merged
Conversation
b3ab8c9 to
ef5afed
Compare
sffc
approved these changes
May 30, 2025
| 1. If _variants_ is not *undefined*, then | ||
| 1. If _variants_ cannot be matched by the <code>unicode_variant_subtag</code> Unicode locale nonterminal, throw a *RangeError* exception. | ||
| 1. For each element _variant_ of StringSplitToList(_variants_, *"-"*), do | ||
| 1. If _variant_ cannot be matched by the <code>unicode_variant_subtag</code> Unicode locale nonterminal, throw a *RangeError* exception. |
Contributor
There was a problem hiding this comment.
It appears that GetLocaleVariants for something like a-variant1-variant2 returns variant1-variant2 so this logic looks correct.
anba
requested changes
May 30, 2025
| 1. Let _variants_ be ? GetOption(_options_, *"variants"*, ~string~, ~empty~, GetLocaleVariants(_baseName_)). | ||
| 1. If _variants_ is not *undefined*, then | ||
| 1. If _variants_ cannot be matched by the <code>unicode_variant_subtag</code> Unicode locale nonterminal, throw a *RangeError* exception. | ||
| 1. For each element _variant_ of StringSplitToList(_variants_, *"-"*), do |
Contributor
There was a problem hiding this comment.
StringSplitToList requires that neither input is the empty string. So we either need to handle the case when variants is the empty String or, alternatively, check if the input restriction on StringSplitToList can be lifted.
Contributor
|
Additionally a new step needs to be added between steps 15-16:
This is needed to handle the case when duplicate variant subtags are present. Like for example: |
…struction Fixes tc39#1006 * `unicode_variant_subtag` applies to a single subtag, not a sequence * duplicate variant subtags must be rejected
ef5afed to
d4f778b
Compare
unicode_variant_subtag against a subtag sequencevariants for Intl.Locale construction
Member
Author
|
Thank you for the thorough review, @anba. |
anba
reviewed
May 31, 2025
| 1. If _variants_ is the empty String, throw a *RangeError* exception. | ||
| 1. For each element _variant_ of StringSplitToList(_variants_, *"-"*), do | ||
| 1. If _variant_ cannot be matched by the <code>unicode_variant_subtag</code> Unicode locale nonterminal, throw a *RangeError* exception. | ||
| 1. If _variants_ contains any duplicate subtags, throw a *RangeError* exception. |
Contributor
There was a problem hiding this comment.
Do we trust that readers know that subtags are to be compared case-insensitively? IsStructurallyValidLanguageTag explicitly converts to lower-case to ensure case-insensitive comparison.
gibson042
added a commit
to gibson042/ecma402
that referenced
this pull request
May 31, 2025
gibson042
added a commit
to gibson042/ecma402
that referenced
this pull request
May 31, 2025
gibson042
added a commit
that referenced
this pull request
May 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1006
unicode_variant_subtagapplies to a single subtag, not a sequence