Vulkan: Fix texture synchronization#8772
Closed
Majora320 wants to merge 2 commits into
Closed
Conversation
ocornut
pushed a commit
that referenced
this pull request
Jul 7, 2025
ocornut
pushed a commit
that referenced
this pull request
Jul 7, 2025
ocornut
added a commit
that referenced
this pull request
Jul 7, 2025
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This fixes two bugs around synchronization when uploading textures to the GPU:
VK_PIPELINE_STAGE_HOST_BIT, but it must also wait for any ongoing reads to be complete withVK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT.vkFlushMappedMemoryRangesstates that it does not guarantee for writes to be available to the device unless a memory dependency is specified onVK_ACCESS_HOST_WRITE_BIT.The first bug is currently caught by the synchronization profile of the validation layers with this message: