Block mid-session consent requests#767
Merged
Merged
Conversation
/fixes #751 Details that consent dialogs may not be displayed while an immersive session is active, and explains that this is a short-term restriction. I chose to go with terminating the session in this case rather than suppressing the consent dialog altogether, since it provides very clear feedback about the error case and doesn't require us to make up new behavior for the permissions in question.
Member
Author
|
Also pinging @blairmacintyre, though I couldn't add you as a reviewer since you haven't been explicitly added as a collaborator for this repo. (We can change that if you'd like!) |
|
|
||
| There are multiple non-XR APIs which cause user agents to request [=explicit consent=] to use a feature. If the user agent will request the user's consent while there is an [=active immersive session=], the user agent MUST [=shut down the session=] prior to displaying the consent request to the user. If the user's consent for the feature had been granted prior to the [=active immersive session=] being created the session does not need to be terminated. | ||
|
|
||
| Note: This limitation is to ensure that there is behavioral parity between all user agents until consensus is reached about how to securely display these types of prompts. It is not expected to be a long term requirement. |
Contributor
There was a problem hiding this comment.
LGTM. I particularly appreciate that the motivation is spelled out. Thank you!
Contributor
|
Looks good. (And I'm happy to be a collaborator) |
johnpallett
reviewed
Jul 17, 2019
Co-Authored-By: johnpallett <johnpallett@google.com>
NellWaliczek
approved these changes
Jul 19, 2019
Member
NellWaliczek
left a comment
There was a problem hiding this comment.
Glad we were able to reach consensus on this temporary measure!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/fixes #751
Details that consent dialogs may not be displayed while an immersive
session is active, and explains that this is a short-term restriction.
I chose to go with terminating the session in this case rather than
suppressing the consent dialog altogether, since it provides very clear
feedback about the error case and doesn't require us to make up new
behavior for the permissions in question.