Move racy parts of requestSession() to the main thread#706
Merged
Conversation
toji
requested changes
Jun 17, 2019
Member
toji
left a comment
There was a problem hiding this comment.
Looks good to me pending the addition of some load-bearing whitespace.
| 1. If |immersive| is <code>true</code>: | ||
| 1. If the algorithm is not [=triggered by user activation=], [=reject=] |promise| with a "{{SecurityError}}" {{DOMException}} and return |promise|. | ||
| 1. If [=pending immersive session=] is <code>true</code> or [=active immersive session=] is not <code>null</code>, [=reject=] |promise| with an "{{InvalidStateError}}" {{DOMException}} and return |promise|. | ||
| 1. Set [=pending immersive session=] to be <code>true</code>. |
Member
There was a problem hiding this comment.
This line appears to need a bit of additional indentation to logically fall under the If immersive is true: condition.
Contributor
Author
|
Fixed! |
Member
|
Thanks you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #643
cc @ddorwin
r? @NellWaliczek