Log stream/topic already exists as debug events.#604
Merged
Conversation
e296908 to
94daf93
Compare
Contributor
|
Maybe this could be extended to all existing (currently 8) |
94daf93 to
595799d
Compare
Contributor
Author
|
Why not! Fixed 😊 |
Contributor
|
Great, there are still some failing tests for the |
a5a861a to
bba95c2
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #604 +/- ##
==========================================
+ Coverage 74.49% 74.50% +0.01%
==========================================
Files 316 316
Lines 23985 23998 +13
Branches 23985 23998 +13
==========================================
+ Hits 17867 17880 +13
- Misses 4325 4330 +5
+ Partials 1793 1788 -5 ☔ View full report in Codecov by Sentry. |
Contributor
|
<3 better error message 👍 |
hubcio
approved these changes
Jan 26, 2024
hageshiame
pushed a commit
to hageshiame/iggy
that referenced
this pull request
Nov 7, 2025
1. Aligned Error Codes and Information with the Rust SDK 2. Refactored IggyError: Discarded Sentinel Errors, Introduced Code(err error) Helper. 3. Updated Tests 4. Removed the Logic for Ignoring xxxAlreadyExists Errors, as referenced in [PR apache#604](apache#604).
ryerraguntla
pushed a commit
to ryerraguntla/iggy_for_influx
that referenced
this pull request
Mar 13, 2026
1. Aligned Error Codes and Information with the Rust SDK 2. Refactored IggyError: Discarded Sentinel Errors, Introduced Code(err error) Helper. 3. Updated Tests 4. Removed the Logic for Ignoring xxxAlreadyExists Errors, as referenced in [PR #604](apache/iggy#604).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To summarize what was discussed on discord:
Attempting to create topics and streams that have already been created currently logs at the error level. For example:
This may happen as a result of users simply to always create a topic upon producer/consumer initialization, as a means to avoid topic/stream not found error handling. One fix would be to require users to check topic existences first, but this would often result in two request being done rather than just one.
Users already need to explicitly ignore this "error" in the SDK, so I think it's ok to simply increase the corresponding log levels to debug. It also makes things easier for users that don't want to filter away all error layer events just to get rid of those.
Currently, however, all logging is handled centrally by
handle_response(), and for each transport backend. This makes it hard to individually tune log levels. This PR solves the tuning by using a conditional for the TCP backend only, but it's a solution that won't scale well at all. Got the go-ahead for this anyway, with the mutual understanding it's merely a temporary change to a solution that would require greater overhaul of the SDK ✌️