ci(python,rust): fix publish dry-run and disable Windows wheels#2813
Merged
Conversation
cargo publish --dry-run resolves dependencies from crates.io, so downstream crates (e.g. iggy_binary_protocol) fail when upstream crates (iggy_common) haven't actually been published. Replace with cargo package --no-verify which validates packaging metadata without the isolated crates.io rebuild — build correctness is already covered by the preceding cargo build step using workspace-local deps. Also temporarily disable Windows Python wheel builds.
mmodzelewski
approved these changes
Feb 24, 2026
spetz
approved these changes
Feb 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2813 +/- ##
============================================
- Coverage 68.44% 68.42% -0.03%
Complexity 656 656
============================================
Files 852 852
Lines 68196 68196
Branches 59657 59667 +10
============================================
- Hits 46679 46664 -15
- Misses 19187 19191 +4
- Partials 2330 2341 +11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
kriti-sc
pushed a commit
to kriti-sc/iggy
that referenced
this pull request
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

cargo publish --dry-run resolves dependencies from crates.io,
so downstream crates (e.g. iggy_binary_protocol) fail when
upstream crates (iggy_common) haven't actually been published.
Replace with cargo package --no-verify which validates
packaging metadata without the isolated crates.io rebuild —
build correctness is already covered by the preceding
cargo build step using workspace-local deps.
Also temporarily disable Windows Python wheel builds.