close
Skip to content

refactor(configs): move ServerConfig types from server to configs crate#2796

Merged
hubcio merged 4 commits into
masterfrom
server-config-refactor
Feb 26, 2026
Merged

refactor(configs): move ServerConfig types from server to configs crate#2796
hubcio merged 4 commits into
masterfrom
server-config-refactor

Conversation

@hubcio
Copy link
Copy Markdown
Contributor

@hubcio hubcio commented Feb 23, 2026

Config types were coupled to the server binary, forcing
dependents to pull in the entire server crate. Move them
to core/configs/ with a thin re-export facade so existing
server imports stay unchanged.

Add TODO for extracting iggy_types leaf crate to break
the configs <-> iggy_common cycle and eliminate the
MemoryPoolConfigOther duplicate.

@hubcio hubcio force-pushed the server-config-refactor branch 2 times, most recently from 709b5dc to 63671aa Compare February 23, 2026 12:00
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 41.71429% with 204 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.48%. Comparing base (514b5c5) to head (1cf4dd7).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
core/server/src/shard_allocator.rs 15.45% 172 Missing and 3 partials ⚠️
core/configs/src/server_config/sharding.rs 82.48% 14 Missing and 10 partials ⚠️
core/configs/src/server_config/validators.rs 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2796      +/-   ##
============================================
+ Coverage     71.44%   71.48%   +0.04%     
  Complexity      708      708              
============================================
  Files           969      970       +1     
  Lines         78219    78195      -24     
  Branches      60029    60013      -16     
============================================
+ Hits          55884    55901      +17     
+ Misses        20002    19949      -53     
- Partials       2333     2345      +12     
Flag Coverage Δ
csharp 67.06% <ø> (-0.19%) ⬇️
java 54.02% <ø> (ø)
node 92.18% <ø> (-0.23%) ⬇️
rust 69.64% <41.71%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
core/common/src/alloc/memory_pool.rs 70.30% <ø> (ø)
core/configs/src/server_config/cache_indexes.rs 27.58% <ø> (ø)
core/configs/src/server_config/defaults.rs 0.00% <ø> (ø)
core/configs/src/server_config/displays.rs 93.04% <ø> (ø)
core/configs/src/server_config/http.rs 66.66% <ø> (ø)
core/configs/src/server_config/server.rs 66.66% <100.00%> (ø)
core/configs/src/server_config/system.rs 94.21% <ø> (ø)
core/configs/src/server_config/websocket.rs 14.70% <ø> (ø)
core/server/src/bootstrap.rs 80.68% <ø> (ø)
core/server/src/main.rs 66.13% <ø> (ø)
... and 4 more

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hubcio hubcio force-pushed the server-config-refactor branch 4 times, most recently from 7229f17 to 555b559 Compare February 25, 2026 09:52
numinnex
numinnex previously approved these changes Feb 25, 2026
Config types were coupled to the server binary, forcing
dependents to pull in the entire server crate. Move them
to core/configs/ with a thin re-export facade so existing
server imports stay unchanged.

Add TODO for extracting iggy_types leaf crate to break
the configs <-> iggy_common cycle and eliminate the
MemoryPoolConfigOther duplicate.
@hubcio hubcio merged commit bcfa50c into master Feb 26, 2026
71 checks passed
@hubcio hubcio deleted the server-config-refactor branch February 26, 2026 17:56
kriti-sc pushed a commit to kriti-sc/iggy that referenced this pull request Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants