close
Skip to content

chore(docs): add java examples and ci tests#2504

Merged
mmodzelewski merged 12 commits into
apache:masterfrom
slbotbm:java-examples
Dec 23, 2025
Merged

chore(docs): add java examples and ci tests#2504
mmodzelewski merged 12 commits into
apache:masterfrom
slbotbm:java-examples

Conversation

@slbotbm
Copy link
Copy Markdown
Contributor

@slbotbm slbotbm commented Dec 19, 2025

closes #1893

Comment thread .github/workflows/_test_examples.yml
@slbotbm
Copy link
Copy Markdown
Contributor Author

slbotbm commented Dec 19, 2025

A few questions:

  1. The getting-started and basic examples are pretty similar - they only have the batch_limit and messages_per_batch different.
  2. The async example in foreign/java/examples still exists. Should that be moved here?

@hubcio
Copy link
Copy Markdown
Contributor

hubcio commented Dec 19, 2025

@slbotbm

  1. lets remove basic then
  2. yes

@slbotbm
Copy link
Copy Markdown
Contributor Author

slbotbm commented Dec 19, 2025

The latest commit adds the async examples to examples/java and deletes the foreign/java/examples directory. Also removes the basic example

@hubert-laserdata
Copy link
Copy Markdown

let's wait for @mmodzelewski review, also maybe @chiradip has any comments :)

@chiradip
Copy link
Copy Markdown
Contributor

I will have a look.

Copy link
Copy Markdown
Member

@mmodzelewski mmodzelewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @slbotbm, thanks a lot for the PR! It looks great, I added just a few minor comments. Please have a look at them and once resolved we'll be able to merge the PR :)

Comment thread examples/java/gradle/wrapper/gradle-wrapper.jar Outdated
Comment thread examples/java/build.gradle.kts Outdated
Comment thread examples/java/build.gradle.kts Outdated
Comment thread examples/java/gradle.properties Outdated
Comment thread examples/java/README.md Outdated
Comment thread examples/java/build.gradle.kts Outdated
Comment thread examples/java/build.gradle.kts Outdated
@mmodzelewski mmodzelewski merged commit c5f1019 into apache:master Dec 23, 2025
54 checks passed
@mmodzelewski
Copy link
Copy Markdown
Member

@slbotbm Many thanks for the contribution. Great work!

@slbotbm
Copy link
Copy Markdown
Contributor Author

slbotbm commented Dec 23, 2025

@hubcio @mmodzelewski Thank you for your constructive comments and guidance, and for making my first contribution experience pleasant; looking forward to collaborating and contributing to iggy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add java SDK examples

6 participants