close
Skip to content

chore(helm): add helm charts#1911

Merged
spetz merged 12 commits into
apache:masterfrom
ilyaaay:add-helm-charts
Jul 10, 2025
Merged

chore(helm): add helm charts#1911
spetz merged 12 commits into
apache:masterfrom
ilyaaay:add-helm-charts

Conversation

@ilyaaay
Copy link
Copy Markdown
Contributor

@ilyaaay ilyaaay commented Jun 25, 2025

No description provided.

@ilyaaay ilyaaay mentioned this pull request Jun 25, 2025
Comment thread helm/charts/iggy-server/Chart.yaml Outdated
Comment thread helm/charts/iggy-server/Chart.yaml Outdated
@spetz
Copy link
Copy Markdown
Contributor

spetz commented Jun 25, 2025

Thanks for the contribution! Besides the minor comments, please ensure that markdown is valid and also run ./scripts/licenses-list.sh --update

@ilyaaay
Copy link
Copy Markdown
Contributor Author

ilyaaay commented Jun 26, 2025

@spetz I added some changes.

Comment thread helm/README.md Outdated
Comment thread helm/charts/iggy-server/values.yaml Outdated
@spetz
Copy link
Copy Markdown
Contributor

spetz commented Jun 27, 2025

@ilyaaay only these 2 things left and then we can merge :) on the other hand, the iggyrs/iggy-web-ui will be updated once we have the apache docker hub for web ui.

@ilyaaay
Copy link
Copy Markdown
Contributor Author

ilyaaay commented Jun 30, 2025

@spetz I finished all problems :)

@spetz
Copy link
Copy Markdown
Contributor

spetz commented Jun 30, 2025

@ilyaaay thanks, let's run the workflows and merge it :)

@spetz
Copy link
Copy Markdown
Contributor

spetz commented Jun 30, 2025

@ilyaaay one more thing, we need all the files to have the appropriate Apache license headers, so please delete the LICENSE and NOTICE files from helm directory, and apply the common license header to all the source files (except README of course). Also, the mardkown linter seems to be failing.

Copy link
Copy Markdown
Contributor

@spetz spetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply the Apache license to all the source files.

@ilyaaay
Copy link
Copy Markdown
Contributor Author

ilyaaay commented Jun 30, 2025

@spetz I also update deps file again and applied your instructions (remove license, disclaimer, notice pull_request_template) files.

@spetz
Copy link
Copy Markdown
Contributor

spetz commented Jun 30, 2025

@ilyaaay the Apache license headers are still missing and the markdown isn't formatted correctly - please check the CI validation errors. You can either run just licenses-fix or add the license headers manually.

@spetz
Copy link
Copy Markdown
Contributor

spetz commented Jul 10, 2025

@ilyaaay unfortunately, markdown is still invalid, could you please fix this, as it seems to be the last issue?

@ilyaaay
Copy link
Copy Markdown
Contributor Author

ilyaaay commented Jul 10, 2025

@spetz yeah, okey

@spetz
Copy link
Copy Markdown
Contributor

spetz commented Jul 10, 2025

@ilyaaay based on the failed CI https://github.com/apache/iggy/actions/runs/16201196091/job/45740724629?pr=1911

helm/charts/iggy-server/README.md:44:72 MD034/no-bare-urls Bare URL used [Context: "https://github.com/coreos/prom..."]

@spetz
Copy link
Copy Markdown
Contributor

spetz commented Jul 10, 2025

Looks good, thank you!

@spetz spetz merged commit 09f608f into apache:master Jul 10, 2025
17 checks passed
hageshiame pushed a commit to hageshiame/iggy that referenced this pull request Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants