fix(server): fix index saving issue on server restart, fix ci#1887
Merged
Conversation
This commit addresses a critical bug where indexes were not marked as saved when the server was restarted with the index cache set to open_segment. This resulted in indexes being saved twice. The fix ensures that indexes are properly marked as saved upon loading from disk, preventing duplicate saves. Additionally, the commit includes: - A new test scenario to verify data integrity after server restart. - Adjustments to the partition storage logic to sort log files before processing. - Improvements in logging for better traceability of message loading and index handling.
056e29d to
61e381f
Compare
61e381f to
cb46b7e
Compare
Contributor
|
Tested locally and looks like this issue is resolved! |
spetz
approved these changes
Jun 20, 2025
hageshiame
pushed a commit
to hageshiame/iggy
that referenced
this pull request
Nov 7, 2025
…#1887) This commit addresses a critical bug where indexes were not marked as saved when the server was restarted with the index cache set to open_segment. This resulted in indexes being saved twice. The fix ensures that indexes are properly marked as saved upon loading from disk, preventing duplicate saves. Additionally, the commit includes: - A new test scenario to verify data integrity after server restart. - Adjustments to the partition storage logic to sort log files before processing. - Improvements in logging for better traceability of message loading and index handling. - Fix to CI scripts which were not properly detecting changes to files in the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses a critical bug where indexes were not marked as saved
when the server was restarted with the index cache set to open_segment. This
resulted in indexes being saved twice. The fix ensures that indexes are
properly marked as saved upon loading from disk, preventing duplicate saves.
Additionally, the commit includes:
processing.
index handling.