feat(repo): move iggy-benchmarks-dashboard to monorepo#1769
Merged
Conversation
f0ce8d9 to
ce48352
Compare
33b594d to
84f536a
Compare
spetz
approved these changes
May 10, 2025
numinnex
approved these changes
May 10, 2025
spetz
pushed a commit
that referenced
this pull request
May 29, 2025
…ttpClient` (#1803) ## Summary This PR aims to provide the following things: * Implement `from_connection_string()` for `QuicClient` and `HttpClient` * Support PAT for `from_connection_string()` * Implement Unit Tests for the usage of `from_connection_string()` from different protocol client * Refactor `ConnectionString` to make it type-sensitive so different clients only have to implement their own `*ConnectionOptions` when trying to support connection string features. * Move `QuicClientConfig` , `HttpClientConfig` and their related structs to iggy_common ## Discussion QUIC requires to know client address, which connection string doesn't provide. Maybe we should try to use some helpers to get it, or we should just neglect client address when using QUIC with connection string ? ## Related Issue #1769 --------- Signed-off-by: I Hsin Cheng <richard120310@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.