Potential fix for code scanning alert no. 5: Implicit narrowing conversion in compound assignment#1313
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
polyzos
pushed a commit
to polyzos/fluss
that referenced
this pull request
Aug 30, 2025
polyzos
pushed a commit
to HZY-Wade/fluss
that referenced
this pull request
Aug 31, 2025
Ugbot
pushed a commit
to Ugbot/fluss
that referenced
this pull request
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/apache/fluss/security/code-scanning/5
To resolve the issue, we can ensure that
timeis explicitly widened to alongtype before addingMILLIS_PER_DAY. This avoids implicit narrowing when the result is assigned back totime. Alternatively, we can change the type oftimeitself tolongto ensure safe arithmetic operations throughout the method. Changingtimetolongis the more robust solution, as it aligns with the type ofMILLIS_PER_DAYand avoids potential issues in other operations involvingtime.Steps to fix:
timeon line 119 frominttolong.timein the method to accommodate the new type.This prevents the need for narrowing conversions and ensures consistency in numeric operations.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.