close
Skip to content

[CI] add apache rat for license check of non java files#1219

Merged
polyzos merged 3 commits into
apache:mainfrom
MehulBatra:ci_license_check_fix
Jul 15, 2025
Merged

[CI] add apache rat for license check of non java files#1219
polyzos merged 3 commits into
apache:mainfrom
MehulBatra:ci_license_check_fix

Conversation

@MehulBatra
Copy link
Copy Markdown
Contributor

@MehulBatra MehulBatra commented Jun 26, 2025

Purpose

Linked issue: close #1215

Enable Apache RAT license header checking in CI pipeline to ensure all files have proper license headers

Brief change log

CI Pipeline:

Added Apache RAT license check step in GitHub Actions workflow check-license.yml to validate license headers on md files.

Maven Configuration:

Removed org.apache.rat plugin management from parent pom.xml

Tests

Caught java extension:
image

Caught md extension
image

API and Format

None

Documentation

None

@MehulBatra
Copy link
Copy Markdown
Contributor Author

@wuchong When you have some time, could you please take a look at this PR? Thank you!

@MehulBatra MehulBatra marked this pull request as draft June 26, 2025 15:18
Comment thread .github/workflows/license-check.yml
Comment thread pom.xml Outdated
@MehulBatra MehulBatra requested a review from wuchong June 26, 2025 15:40
@MehulBatra MehulBatra marked this pull request as ready for review June 26, 2025 15:40
@MehulBatra MehulBatra changed the title [CI] switch to apache rat for license check [CI] add apache rat for license check of non java files Jun 26, 2025
Comment thread pom.xml
Copy link
Copy Markdown
Contributor Author

@MehulBatra MehulBatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address Jark comments

@MehulBatra MehulBatra requested a review from wuchong June 30, 2025 20:39
@polyzos polyzos merged commit 61d82a1 into apache:main Jul 15, 2025
4 checks passed
platinumhamburg pushed a commit to platinumhamburg/fluss that referenced this pull request Jul 18, 2025
* switch to apache rat for license check

* address jark comments

* Address Jark comment
polyzos pushed a commit to polyzos/fluss that referenced this pull request Aug 30, 2025
* switch to apache rat for license check

* address jark comments

* Address Jark comment
polyzos pushed a commit to HZY-Wade/fluss that referenced this pull request Aug 31, 2025
* switch to apache rat for license check

* address jark comments

* Address Jark comment
Ugbot pushed a commit to Ugbot/fluss that referenced this pull request Apr 26, 2026
* switch to apache rat for license check

* address jark comments

* Address Jark comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI]Check License CI fails to detect missing license headers in non-Java files

3 participants