close
Skip to content

Fix conversation accounts for migrated users#655

Merged
akirk merged 2 commits into
mainfrom
fix/conversation-accounts-for-migrated-users
Apr 14, 2026
Merged

Fix conversation accounts for migrated users#655
akirk merged 2 commits into
mainfrom
fix/conversation-accounts-for-migrated-users

Conversation

@akirk
Copy link
Copy Markdown
Owner

@akirk akirk commented Apr 14, 2026

Summary

  • When WP users were migrated to Friend terms, their post_author became 0 on existing conversation posts
  • The Mastodon API conversation endpoint returned empty accounts arrays for these conversations
  • This caused Tusky (and potentially other clients) to crash with IndexOutOfBoundsException when rendering conversations
  • Fix: fall back to friends_feed_url post meta to resolve the account when post_author is 0

Test plan

  • Check /api/v1/conversations returns non-empty accounts for all conversations
  • Verify conversations from remote users (previously migrated) show the correct account
Changelog
  • Automatically create a changelog entry from the details below

Type

  • Fixed

Message

Fix conversation accounts for migrated users by falling back to friends_feed_url meta when post_author is 0.

Test in WordPress Playground

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 14, 2026

Test this PR in WordPress Playground

You can test this pull request directly in WordPress Playground:

Launch WordPress Playground

This will install and activate the plugin with the changes from this PR.

When post_author is 0 (WP users migrated to Friend terms), fall back to
the friends_feed_url post meta to resolve the account. This prevents
conversations from having empty accounts arrays, which crashes Tusky.
@akirk akirk force-pushed the fix/conversation-accounts-for-migrated-users branch from 86a7ebc to 0dc0e7f Compare April 14, 2026 17:37
@akirk akirk merged commit 5c9bb47 into main Apr 14, 2026
@akirk akirk deleted the fix/conversation-accounts-for-migrated-users branch April 14, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant