Fix: Font size picker does not correctly handles big font sizes. by jorgefilipecosta · Pull Request #26705 · WordPress/gutenberg

jorgefilipecosta · 2020-11-04T18:39:13Z

Makes the font size picker selector not render any font size with a size bigger than 25px.

Before:

After:

github-actions · 2020-11-04T18:48:40Z

Size Change: +22 B (0%)

Total Size: 1.21 MB

Filename	Size	Change
`build/components/index.js`	172 kB	+22 B (0%)

ℹ️ View Unchanged

Filename	Size	Change
`build/a11y/index.js`	1.14 kB	0 B
`build/annotations/index.js`	3.78 kB	0 B
`build/api-fetch/index.js`	3.45 kB	0 B
`build/autop/index.js`	2.84 kB	0 B
`build/blob/index.js`	665 B	0 B
`build/block-directory/index.js`	8.72 kB	0 B
`build/block-directory/style-rtl.css`	943 B	0 B
`build/block-directory/style.css`	942 B	0 B
`build/block-editor/index.js`	131 kB	0 B
`build/block-editor/style-rtl.css`	11.1 kB	0 B
`build/block-editor/style.css`	11.1 kB	0 B
`build/block-library/editor-rtl.css`	9.06 kB	0 B
`build/block-library/editor.css`	9.06 kB	0 B
`build/block-library/index.js`	147 kB	0 B
`build/block-library/style-rtl.css`	7.9 kB	0 B
`build/block-library/style.css`	7.9 kB	0 B
`build/block-library/theme-rtl.css`	837 B	0 B
`build/block-library/theme.css`	838 B	0 B
`build/block-serialization-default-parser/index.js`	1.88 kB	0 B
`build/block-serialization-spec-parser/index.js`	3.1 kB	0 B
`build/blocks/index.js`	48.1 kB	0 B
`build/components/style-rtl.css`	15.2 kB	0 B
`build/components/style.css`	15.2 kB	0 B
`build/compose/index.js`	9.81 kB	0 B
`build/core-data/index.js`	12.5 kB	0 B
`build/data-controls/index.js`	772 B	0 B
`build/data/index.js`	8.77 kB	0 B
`build/date/index.js`	31.8 kB	0 B
`build/deprecated/index.js`	768 B	0 B
`build/dom-ready/index.js`	571 B	0 B
`build/dom/index.js`	4.46 kB	0 B
`build/edit-navigation/index.js`	11.2 kB	0 B
`build/edit-navigation/style-rtl.css`	881 B	0 B
`build/edit-navigation/style.css`	885 B	0 B
`build/edit-post/index.js`	306 kB	0 B
`build/edit-post/style-rtl.css`	6.41 kB	0 B
`build/edit-post/style.css`	6.39 kB	0 B
`build/edit-site/index.js`	22.5 kB	0 B
`build/edit-site/style-rtl.css`	3.88 kB	0 B
`build/edit-site/style.css`	3.88 kB	0 B
`build/edit-widgets/index.js`	26.3 kB	0 B
`build/edit-widgets/style-rtl.css`	3.13 kB	0 B
`build/edit-widgets/style.css`	3.13 kB	0 B
`build/editor/editor-styles-rtl.css`	480 B	0 B
`build/editor/editor-styles.css`	482 B	0 B
`build/editor/index.js`	43.1 kB	0 B
`build/editor/style-rtl.css`	3.85 kB	0 B
`build/editor/style.css`	3.85 kB	0 B
`build/element/index.js`	4.65 kB	0 B
`build/escape-html/index.js`	735 B	0 B
`build/format-library/index.js`	7.7 kB	0 B
`build/format-library/style-rtl.css`	547 B	0 B
`build/format-library/style.css`	548 B	0 B
`build/hooks/index.js`	2.16 kB	0 B
`build/html-entities/index.js`	623 B	0 B
`build/i18n/index.js`	3.57 kB	0 B
`build/is-shallow-equal/index.js`	712 B	0 B
`build/keyboard-shortcuts/index.js`	2.52 kB	0 B
`build/keycodes/index.js`	1.94 kB	0 B
`build/list-reusable-blocks/index.js`	3.11 kB	0 B
`build/list-reusable-blocks/style-rtl.css`	476 B	0 B
`build/list-reusable-blocks/style.css`	476 B	0 B
`build/media-utils/index.js`	5.34 kB	0 B
`build/notices/index.js`	1.79 kB	0 B
`build/nux/index.js`	3.42 kB	0 B
`build/nux/style-rtl.css`	671 B	0 B
`build/nux/style.css`	668 B	0 B
`build/plugins/index.js`	2.56 kB	0 B
`build/primitives/index.js`	1.43 kB	0 B
`build/priority-queue/index.js`	791 B	0 B
`build/redux-routine/index.js`	2.85 kB	0 B
`build/reusable-blocks/index.js`	3.06 kB	0 B
`build/rich-text/index.js`	13.2 kB	0 B
`build/server-side-render/index.js`	2.77 kB	0 B
`build/shortcode/index.js`	1.69 kB	0 B
`build/token-list/index.js`	1.27 kB	0 B
`build/url/index.js`	4.06 kB	0 B
`build/viewport/index.js`	1.84 kB	0 B
`build/warning/index.js`	1.14 kB	0 B
`build/wordcount/index.js`	1.22 kB	0 B

_{compressed-size-action}

kjellr

Much better! Thank you @jorgefilipecosta.

talldan · 2020-12-10T07:26:27Z

This was mentioned again here - #27606.

Seems like we forgot to add the backport label to this so it missed WordPress 5.6. I've added the label to backport it to 5.6.1 whenever that might be.

)

These are backports coming for the 5.6.1 release. Summary of the following issues: * [#27970](WordPress/gutenberg#27970) - Fix editor crash when registering a block pattern without `categories` Backport to WP Minor Release [Feature] Inserter [Feature] Patterns [Type] Bug * [#27733](WordPress/gutenberg#27733) - [Embed block]: Add html and reusable support back Backport to WP Minor Release [Block] Embed [Type] Regression * [#27727](WordPress/gutenberg#27727) - Add aria labels to box control component inputs/button Backport to WP Minor Release [Feature] UI Components [Package] Components [Type] Bug [a11y] Labelling * [#27627](WordPress/gutenberg#27627) - HTML Block: Fix editor styles Backport to WP Minor Release [Block] HTML [Type] Regression * [#27526](WordPress/gutenberg#27526) - Core Data: Normalize `_fields` value for use in `stableKey` Backport to WP Minor Release [Package] Core data [Type] Bug * [#26705](WordPress/gutenberg#26705) - Fix: Font size picker does not correctly handles big font sizes. Backport to WP Minor Release [Type] Bug * [#26432](WordPress/gutenberg#26432) - Edit Site: prevent inserter overscroll Backport to WP Minor Release First-time Contributor [Feature] Full Site Editing [Type] Bug Packages updated: @wordpress/block-directory@1.17.7 @wordpress/block-editor@5.1.6 @wordpress/block-library@2.26.7 @wordpress/components@11.1.4 @wordpress/core-data@2.24.3 @wordpress/edit-post@3.25.7 @wordpress/edit-site@1.15.7 @wordpress/edit-widgets@1.1.7 @wordpress/editor@9.24.6 @wordpress/format-library@1.25.6 @wordpress/interface@0.10.7 @wordpress/list-reusable-blocks@1.24.4 @wordpress/nux@3.23.4 @wordpress/reusable-blocks@1.0.6 @wordpress/server-side-render@1.19.4 Fixes #52391. Props gziolo, whyisjake. git-svn-id: https://develop.svn.wordpress.org/branches/5.6@50061 602fd350-edb4-49c9-b593-d223f7449a82

These are backports coming for the 5.6.1 release. Summary of the following issues: * [#27970](WordPress/gutenberg#27970) - Fix editor crash when registering a block pattern without `categories` Backport to WP Minor Release [Feature] Inserter [Feature] Patterns [Type] Bug * [#27733](WordPress/gutenberg#27733) - [Embed block]: Add html and reusable support back Backport to WP Minor Release [Block] Embed [Type] Regression * [#27727](WordPress/gutenberg#27727) - Add aria labels to box control component inputs/button Backport to WP Minor Release [Feature] UI Components [Package] Components [Type] Bug [a11y] Labelling * [#27627](WordPress/gutenberg#27627) - HTML Block: Fix editor styles Backport to WP Minor Release [Block] HTML [Type] Regression * [#27526](WordPress/gutenberg#27526) - Core Data: Normalize `_fields` value for use in `stableKey` Backport to WP Minor Release [Package] Core data [Type] Bug * [#26705](WordPress/gutenberg#26705) - Fix: Font size picker does not correctly handles big font sizes. Backport to WP Minor Release [Type] Bug * [#26432](WordPress/gutenberg#26432) - Edit Site: prevent inserter overscroll Backport to WP Minor Release First-time Contributor [Feature] Full Site Editing [Type] Bug Packages updated: @wordpress/block-directory@1.17.7 @wordpress/block-editor@5.1.6 @wordpress/block-library@2.26.7 @wordpress/components@11.1.4 @wordpress/core-data@2.24.3 @wordpress/edit-post@3.25.7 @wordpress/edit-site@1.15.7 @wordpress/edit-widgets@1.1.7 @wordpress/editor@9.24.6 @wordpress/format-library@1.25.6 @wordpress/interface@0.10.7 @wordpress/list-reusable-blocks@1.24.4 @wordpress/nux@3.23.4 @wordpress/reusable-blocks@1.0.6 @wordpress/server-side-render@1.19.4 Fixes #52391. Props gziolo, whyisjake. Built from https://develop.svn.wordpress.org/branches/5.6@50061 git-svn-id: http://core.svn.wordpress.org/branches/5.6@49762 1a063a9b-81f0-0310-95a4-ce76da25c4cd

These are backports coming for the 5.6.1 release. Summary of the following issues: * [#27970](WordPress/gutenberg#27970) - Fix editor crash when registering a block pattern without `categories` Backport to WP Minor Release [Feature] Inserter [Feature] Patterns [Type] Bug * [#27733](WordPress/gutenberg#27733) - [Embed block]: Add html and reusable support back Backport to WP Minor Release [Block] Embed [Type] Regression * [#27727](WordPress/gutenberg#27727) - Add aria labels to box control component inputs/button Backport to WP Minor Release [Feature] UI Components [Package] Components [Type] Bug [a11y] Labelling * [#27627](WordPress/gutenberg#27627) - HTML Block: Fix editor styles Backport to WP Minor Release [Block] HTML [Type] Regression * [#27526](WordPress/gutenberg#27526) - Core Data: Normalize `_fields` value for use in `stableKey` Backport to WP Minor Release [Package] Core data [Type] Bug * [#26705](WordPress/gutenberg#26705) - Fix: Font size picker does not correctly handles big font sizes. Backport to WP Minor Release [Type] Bug * [#26432](WordPress/gutenberg#26432) - Edit Site: prevent inserter overscroll Backport to WP Minor Release First-time Contributor [Feature] Full Site Editing [Type] Bug Packages updated: @wordpress/block-directory@1.17.7 @wordpress/block-editor@5.1.6 @wordpress/block-library@2.26.7 @wordpress/components@11.1.4 @wordpress/core-data@2.24.3 @wordpress/edit-post@3.25.7 @wordpress/edit-site@1.15.7 @wordpress/edit-widgets@1.1.7 @wordpress/editor@9.24.6 @wordpress/format-library@1.25.6 @wordpress/interface@0.10.7 @wordpress/list-reusable-blocks@1.24.4 @wordpress/nux@3.23.4 @wordpress/reusable-blocks@1.0.6 @wordpress/server-side-render@1.19.4 Fixes #52391. Props gziolo, whyisjake. Built from https://develop.svn.wordpress.org/branches/5.6@50061 git-svn-id: https://core.svn.wordpress.org/branches/5.6@49762 1a063a9b-81f0-0310-95a4-ce76da25c4cd

inc2734 · 2021-02-04T06:34:50Z

After updating to WordPress 5.6.1, the text size setting for paragraph blocks is no longer reflected.

All options are displayed at the same size, and the default is selected no matter which one I choose.

Undoing this pull request change will allow you to select correctly.

tollhaus · 2021-02-04T16:11:13Z

Same problem here.

talldan · 2021-02-15T08:53:05Z

This was shipped in 5.6.1, so removing the backport label:
https://make.wordpress.org/core/2021/01/28/wordpress-5-6-1-rc1/

These are backports coming for the 5.6.1 release. Summary of the following issues: * [#27970](WordPress/gutenberg#27970) - Fix editor crash when registering a block pattern without `categories` Backport to WP Minor Release [Feature] Inserter [Feature] Patterns [Type] Bug * [#27733](WordPress/gutenberg#27733) - [Embed block]: Add html and reusable support back Backport to WP Minor Release [Block] Embed [Type] Regression * [#27727](WordPress/gutenberg#27727) - Add aria labels to box control component inputs/button Backport to WP Minor Release [Feature] UI Components [Package] Components [Type] Bug [a11y] Labelling * [#27627](WordPress/gutenberg#27627) - HTML Block: Fix editor styles Backport to WP Minor Release [Block] HTML [Type] Regression * [#27526](WordPress/gutenberg#27526) - Core Data: Normalize `_fields` value for use in `stableKey` Backport to WP Minor Release [Package] Core data [Type] Bug * [#26705](WordPress/gutenberg#26705) - Fix: Font size picker does not correctly handles big font sizes. Backport to WP Minor Release [Type] Bug * [#26432](WordPress/gutenberg#26432) - Edit Site: prevent inserter overscroll Backport to WP Minor Release First-time Contributor [Feature] Full Site Editing [Type] Bug Packages updated: @wordpress/block-directory@1.17.7 @wordpress/block-editor@5.1.6 @wordpress/block-library@2.26.7 @wordpress/components@11.1.4 @wordpress/core-data@2.24.3 @wordpress/edit-post@3.25.7 @wordpress/edit-site@1.15.7 @wordpress/edit-widgets@1.1.7 @wordpress/editor@9.24.6 @wordpress/format-library@1.25.6 @wordpress/interface@0.10.7 @wordpress/list-reusable-blocks@1.24.4 @wordpress/nux@3.23.4 @wordpress/reusable-blocks@1.0.6 @wordpress/server-side-render@1.19.4 Fixes #52391. Props gziolo, whyisjake. Built from https://develop.svn.wordpress.org/branches/5.6@50061 git-svn-id: http://core.svn.wordpress.org/branches/5.6@49762 1a063a9b-81f0-0310-95a4-ce76da25c4cd

Fix: Font size picker does not correctly handles big font sizes.

7bface1

jorgefilipecosta added the [Type] Bug An existing feature does not function as intended label Nov 4, 2020

jorgefilipecosta requested review from ajitbohra and chrisvanpatten as code owners November 4, 2020 18:39

jorgefilipecosta self-assigned this Nov 4, 2020

jorgefilipecosta requested a review from kjellr November 4, 2020 19:21

kjellr approved these changes Nov 4, 2020

View reviewed changes

jorgefilipecosta merged commit 6bae656 into master Nov 4, 2020

jorgefilipecosta deleted the fix/font-size-picker-does-not-correctly-handles-big-font-sizes branch November 4, 2020 22:02

github-actions Bot added this to the Gutenberg 9.4 milestone Nov 4, 2020

talldan added the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Dec 10, 2020

talldan mentioned this pull request Dec 10, 2020

Heading block: the font size drop-down options gets overlap with each other #27606

Closed

whyisjake pushed a commit that referenced this pull request Jan 28, 2021

Fix: Font size picker does not correctly handles big font sizes. (#26705

81e1479

)

gwwar mentioned this pull request Feb 4, 2021

WP 5.6.1 FontSize Select doesn't Work #28738

Closed

talldan mentioned this pull request Feb 5, 2021

Reflect text size in FontSizePicker choices #28761

Closed

6 tasks

talldan removed the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Feb 15, 2021

maperezotero mentioned this pull request Feb 16, 2021

Gutenberg font-size doesn't work Automattic/_s#1483

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Font size picker does not correctly handles big font sizes.#26705

Fix: Font size picker does not correctly handles big font sizes.#26705
jorgefilipecosta merged 1 commit into
masterfrom
fix/font-size-picker-does-not-correctly-handles-big-font-sizes

jorgefilipecosta commented Nov 4, 2020

Uh oh!

github-actions Bot commented Nov 4, 2020

Uh oh!

kjellr left a comment

Uh oh!

talldan commented Dec 10, 2020

Uh oh!

inc2734 commented Feb 4, 2021

Uh oh!

tollhaus commented Feb 4, 2021

Uh oh!

talldan commented Feb 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

jorgefilipecosta commented Nov 4, 2020

Uh oh!

github-actions Bot commented Nov 4, 2020

Uh oh!

kjellr left a comment

Choose a reason for hiding this comment

Uh oh!

talldan commented Dec 10, 2020

Uh oh!

inc2734 commented Feb 4, 2021

Uh oh!

tollhaus commented Feb 4, 2021

Uh oh!

talldan commented Feb 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants