fix(sdk): The LatestEventValue is erased when a room has been emptied#6035
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6035 +/- ##
==========================================
- Coverage 88.93% 88.93% -0.01%
==========================================
Files 358 358
Lines 99177 99272 +95
Branches 99177 99272 +95
==========================================
+ Hits 88204 88287 +83
- Misses 6992 7000 +8
- Partials 3981 3985 +4 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Jan 16, 2026
Contributor
poljar
left a comment
There was a problem hiding this comment.
Makes sense, please just clarify the comment about what's happening bit.
This patch ensures that a `LatestEventValue` is erased when a room has been emptied. If we are computing a value from the Event Cache, it's because we have received an update from the Event Cache. This update falls in two categories: either an event has been added or updated, or the room has been emptied. We consider the room has been emptied by default. If we are able to scan at least one in-memory event, we consider the room has not been emptied. This patch adds one specific, and updates other tests that were using an empty Event Cache (which now produces a different result in this situation).
This patch adds a test to ensure the `LatestEventValue` is re-computed (more specifically: erased) when a user is ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This patch is twofold:
LatestEventValueis erased when a room has been emptied,LatestEventValueis re-computed when a user is ignored.Best to review one patch at a time.