fix(latest event): mark a recoverable failure to send as a sending item#6016
Merged
Conversation
bnjbvr
commented
Jan 12, 2026
Comment on lines
+887
to
+895
| if *is_recoverable { | ||
| // If the room send queue error is recoverable, the send queue may retry to send | ||
| // it in a short while, so the event should still be considered | ||
| // sending. Leave it to that, at this point. | ||
| buffer_of_values_for_local_events.mark_is_sending_from(transaction_id); | ||
| } else { | ||
| // If the error isn't recoverable, mark as a true "cannot be sent". | ||
| buffer_of_values_for_local_events.mark_cannot_be_sent_from(transaction_id); | ||
| } |
Hywan
approved these changes
Jan 12, 2026
Member
Hywan
left a comment
There was a problem hiding this comment.
Thanks for the patch! I believe it indeed fixes a bug. I left a small comment, but I'm approving ahead of time to save one review trip.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6016 +/- ##
=======================================
Coverage 88.94% 88.94%
=======================================
Files 357 357
Lines 99111 99146 +35
Branches 99111 99146 +35
=======================================
+ Hits 88155 88189 +34
+ Misses 6977 6975 -2
- Partials 3979 3982 +3 ☔ View full report in Codecov by Sentry. |
… sending In the send queue, failures to send can be classified into two categories: - permanent failures (e.g. invalid parameters) - recoverable failures (e.g. network is down; server responded with a transient error code) The latest event system would classify all the failures as "cannot be sent", which is slightly incorrect if the failure was recoverable. In this case, we should still consider the local event as being sent, as the system should try to send it some time soon.
0eeb084 to
3364225
Compare
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
Contributor
Author
|
@jmartinesp confirmed (thanks!) this fixes the symptoms observable in element-hq/element-x-android#5885. Merging now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the send queue, failures to send can be classified into two
categories:
transient error code)
The latest event system would classify all the failures as "cannot be
sent", which is slightly incorrect if the failure was recoverable. In
this case, we should still consider the local event as being sent, as
the system should try to send it some time soon.
I think this should fix element-hq/element-x-android#5885, I'll ask for some confirmation from one of the people who could repro the issue.