close
Skip to content

feat(ffi): Add ffi::CreateRoomParameters::is_space#6010

Merged
jmartinesp merged 2 commits into
mainfrom
feat/add-is-space-parameter-to-room-creation-params
Jan 9, 2026
Merged

feat(ffi): Add ffi::CreateRoomParameters::is_space#6010
jmartinesp merged 2 commits into
mainfrom
feat/add-is-space-parameter-to-room-creation-params

Conversation

@jmartinesp
Copy link
Copy Markdown
Contributor

@jmartinesp jmartinesp commented Jan 8, 2026

This allows us to create spaces - rooms with a RoomType::Space - from the clients.

  • Public API changes documented in changelogs (optional)

Signed-off-by:

This allows us to create a room with a `RoomType::Space` from the clients
@jmartinesp jmartinesp force-pushed the feat/add-is-space-parameter-to-room-creation-params branch from f8531bb to 35ee3de Compare January 8, 2026 12:10
@jmartinesp jmartinesp marked this pull request as ready for review January 8, 2026 12:11
@jmartinesp jmartinesp requested a review from a team as a code owner January 8, 2026 12:11
@jmartinesp jmartinesp requested review from a team and poljar and removed request for a team and poljar January 8, 2026 12:11
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.94%. Comparing base (97110ed) to head (b6e9875).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6010   +/-   ##
=======================================
  Coverage   88.93%   88.94%           
=======================================
  Files         357      357           
  Lines       99166    99166           
  Branches    99166    99166           
=======================================
+ Hits        88195    88199    +4     
+ Misses       6980     6975    -5     
- Partials     3991     3992    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 8, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing feat/add-is-space-parameter-to-room-creation-params (b6e9875) with main (f3aec8d)

Summary

✅ 50 untouched benchmarks

Copy link
Copy Markdown
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test would be welcomed, but I'm okay with the current patch, thanks!

@jmartinesp
Copy link
Copy Markdown
Contributor Author

jmartinesp commented Jan 9, 2026

All the code is in the FFI layer, so I'm not sure if we can actually test it.


Oh, we can. We just don't bother most of the time because it's FFI <-> SDK mappings.

@jmartinesp jmartinesp enabled auto-merge (rebase) January 9, 2026 10:53
@jmartinesp jmartinesp merged commit 7595ae0 into main Jan 9, 2026
52 checks passed
@jmartinesp jmartinesp deleted the feat/add-is-space-parameter-to-room-creation-params branch January 9, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants