feat(ffi): Add ffi::CreateRoomParameters::is_space#6010
Merged
jmartinesp merged 2 commits intoJan 9, 2026
Conversation
This allows us to create a room with a `RoomType::Space` from the clients
f8531bb to
35ee3de
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6010 +/- ##
=======================================
Coverage 88.93% 88.94%
=======================================
Files 357 357
Lines 99166 99166
Branches 99166 99166
=======================================
+ Hits 88195 88199 +4
+ Misses 6980 6975 -5
- Partials 3991 3992 +1 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
Hywan
approved these changes
Jan 9, 2026
Member
Hywan
left a comment
There was a problem hiding this comment.
A test would be welcomed, but I'm okay with the current patch, thanks!
Contributor
Author
|
All the code is in the FFI layer, so I'm not sure if we can actually test it. Oh, we can. We just don't bother most of the time because it's FFI <-> SDK mappings. |
…equest` transformation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This allows us to create spaces - rooms with a
RoomType::Space- from the clients.Signed-off-by: