close
Skip to content

Fix: Focus loss when button goes to disabled state#608

Merged
dkotter merged 4 commits into
WordPress:developfrom
hbhalodia:fix/issue-589-2
May 27, 2026
Merged

Fix: Focus loss when button goes to disabled state#608
dkotter merged 4 commits into
WordPress:developfrom
hbhalodia:fix/issue-589-2

Conversation

@hbhalodia
Copy link
Copy Markdown
Contributor

@hbhalodia hbhalodia commented May 22, 2026

What?

Part of - #589

Why?

  • PR is necessary to add the focus so there is no focus lost when button is in disabled state

How?

  • PR adds the prop accessibleWhenDisabled prop so the focus does not lost while button goes to disabled mode

Use of AI Tools

  • None

Testing Instructions

  1. Check the button added for experiments, For summarization, title generation and suggestion experiments.
  2. The focus should not be lost

Screenshots or screencast

Before After

Changelog Entry

Fixed - Fix focus lost when button goes to disabled state.

Open WordPress Playground Preview

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org>
Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: dkotter <dkotter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.00%. Comparing base (3624c91) to head (55b874f).
⚠️ Report is 10 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #608      +/-   ##
=============================================
+ Coverage      73.18%   74.00%   +0.82%     
- Complexity      1731     1738       +7     
=============================================
  Files             85       85              
  Lines           7473     7490      +17     
=============================================
+ Hits            5469     5543      +74     
+ Misses          2004     1947      -57     
Flag Coverage Δ
unit 74.00% <ø> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@yogeshbhutkar yogeshbhutkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌻

@jeffpaul jeffpaul added this to the 1.1.0 milestone May 26, 2026
Comment thread src/experiments/content-classification/components/SuggestionPanel.tsx Outdated
@dkotter dkotter modified the milestones: 1.0.1, 1.1.0 May 26, 2026
@jeffpaul jeffpaul linked an issue May 27, 2026 that may be closed by this pull request
@dkotter dkotter modified the milestones: 1.1.0, 1.0.1 May 27, 2026
@dkotter dkotter merged commit c818723 into WordPress:develop May 27, 2026
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

a11y: Focus is lost on many button actions

4 participants