close
Skip to content

Resolve some cases of #132279 by using the right typing mode in the next solver#156141

Merged
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
jdonszelmann:use-right-typingmode
May 8, 2026
Merged

Resolve some cases of #132279 by using the right typing mode in the next solver#156141
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
jdonszelmann:use-right-typingmode

Conversation

@jdonszelmann
Copy link
Copy Markdown
Contributor

@jdonszelmann jdonszelmann commented May 4, 2026 •
edited by rustbot
Loading

View all comments

r? @lcnr

Convert 3 FIXMEs of #132279 to using the right typing mode when we can (tcx.use_typing_mode_borrowck())

Also resolves #155093, which I closed

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 4, 2026
@jdonszelmann jdonszelmann mentioned this pull request May 4, 2026
Closed
@jdonszelmann jdonszelmann force-pushed the use-right-typingmode branch 4 times, most recently from bac5eb5 to 7d76533 Compare May 4, 2026 13:28
@jdonszelmann jdonszelmann marked this pull request as ready for review May 4, 2026 13:28
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 4, 2026

Some changes occurred to constck

cc @fee1-dead

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 4, 2026
lcnr
lcnr reviewed May 4, 2026
View reviewed changes
Comment thread compiler/rustc_const_eval/src/check_consts/qualifs.rs Outdated
Comment thread compiler/rustc_middle/src/mir/mod.rs Outdated
Comment thread compiler/rustc_infer/src/infer/mod.rs Outdated
@lcnr
Copy link
Copy Markdown
Contributor

lcnr commented May 4, 2026

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 4, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@jdonszelmann jdonszelmann force-pushed the use-right-typingmode branch from 7d76533 to a59bc36 Compare May 5, 2026 11:46
@rustbot

This comment has been minimized.

Sign in to view
@jdonszelmann
Copy link
Copy Markdown
Contributor Author

jdonszelmann commented May 5, 2026

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 5, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
lcnr
lcnr reviewed May 5, 2026
View reviewed changes
Comment thread compiler/rustc_infer/src/infer/mod.rs
@jdonszelmann jdonszelmann force-pushed the use-right-typingmode branch from a59bc36 to da70164 Compare May 6, 2026 08:10
@jdonszelmann
Copy link
Copy Markdown
Contributor Author

jdonszelmann commented May 6, 2026

@bors r=lcnr

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 6, 2026

📌 Commit da70164 has been approved by lcnr

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2026
@jdonszelmann
Copy link
Copy Markdown
Contributor Author

jdonszelmann commented May 6, 2026

@bors rollupo

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 6, 2026
@JonathanBrouwer
Rollup merge of rust-lang#156141 - jdonszelmann:use-right-typingmode,…
8846256 
… r=lcnr

Resolve some cases of rust-lang#132279 by using the right typing mode in the next solver

r? @lcnr

Convert 3 FIXMEs of rust-lang#132279 to using the right typing mode when we can (`tcx.use_typing_mode_borrowck()`)

Also resolves rust-lang#155093, which I closed
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 6, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 6, 2026
@JonathanBrouwer
Rollup merge of rust-lang#156141 - jdonszelmann:use-right-typingmode,…
4e6d04e 
… r=lcnr

Resolve some cases of rust-lang#132279 by using the right typing mode in the next solver

r? @lcnr

Convert 3 FIXMEs of rust-lang#132279 to using the right typing mode when we can (`tcx.use_typing_mode_borrowck()`)

Also resolves rust-lang#155093, which I closed
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 6, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 6, 2026
@JonathanBrouwer
Rollup merge of rust-lang#156141 - jdonszelmann:use-right-typingmode,…
4f4138a 
… r=lcnr

Resolve some cases of rust-lang#132279 by using the right typing mode in the next solver

r? @lcnr

Convert 3 FIXMEs of rust-lang#132279 to using the right typing mode when we can (`tcx.use_typing_mode_borrowck()`)

Also resolves rust-lang#155093, which I closed
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 6, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request May 6, 2026
@bors
Auto merge of #156238 - JonathanBrouwer:rollup-VXvD19K, r=JonathanBro…
3fcb893 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #146273 (lint ImproperCTypes: refactor linting architecture (part 2))
 - #156173 (Fewer global node_id_to_def_id lookups)
 - #155961 (Deny warnings in the test for crates that are available on stable)
 - #156130 (Fold/visit tweaks)
 - #156131 (Metadata macro/query cleanups)
 - #156141 (Resolve some cases of #132279 by using the right typing mode in the next solver)
 - #156202 (llvm: Use correct type for splat mask)
@JonathanBrouwer
Copy link
Copy Markdown
Contributor

JonathanBrouwer commented May 6, 2026

@bors r-
#156238 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 6, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 6, 2026

This pull request was unapproved.

This PR was contained in a rollup (#156238), which was unapproved.

View changes since this unapproval

@jdonszelmann jdonszelmann force-pushed the use-right-typingmode branch from da70164 to ef8be30 Compare May 7, 2026 05:06
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jdonszelmann jdonszelmann force-pushed the use-right-typingmode branch from ef8be30 to 0d65aa2 Compare May 8, 2026 12:40
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 8, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@lcnr
Copy link
Copy Markdown
Contributor

lcnr commented May 8, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 8, 2026

📌 Commit 0d65aa2 has been approved by lcnr

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 8, 2026
@matthiaskrgr matthiaskrgr mentioned this pull request May 8, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request May 8, 2026
@bors
Auto merge of #156341 - matthiaskrgr:rollup-MPIc60x, r=matthiaskrgr
fb0a5a5 
Rollup of 5 pull requests

Successful merges:

 - #156141 (Resolve some cases of #132279 by using the right typing mode in the next solver)
 - #156244 (fix incorrect suggestions in private import diagnostic)
 - #156306 (Move tests consts)
 - #156333 (Avoid invalid spans in dotdotdot rest pattern suggestions)
 - #156337 (rustc-dev-guide subtree update)
@rust-bors rust-bors Bot merged commit dbc4f62 into rust-lang:main May 8, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone May 8, 2026
rust-timer added a commit that referenced this pull request May 8, 2026
@rust-timer
Unrolled build for #156141
d67a5b4 
Rollup merge of #156141 - jdonszelmann:use-right-typingmode, r=lcnr

Resolve some cases of #132279 by using the right typing mode in the next solver

r? @lcnr

Convert 3 FIXMEs of #132279 to using the right typing mode when we can (`tcx.use_typing_mode_borrowck()`)

Also resolves #155093, which I closed
github-actions Bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request May 18, 2026
@bors
Auto merge of #156341 - matthiaskrgr:rollup-MPIc60x, r=matthiaskrgr
eb6d4e3 
Rollup of 5 pull requests

Successful merges:

 - rust-lang/rust#156141 (Resolve some cases of rust-lang/rust#132279 by using the right typing mode in the next solver)
 - rust-lang/rust#156244 (fix incorrect suggestions in private import diagnostic)
 - rust-lang/rust#156306 (Move tests consts)
 - rust-lang/rust#156333 (Avoid invalid spans in dotdotdot rest pattern suggestions)
 - rust-lang/rust#156337 (rustc-dev-guide subtree update)
@lqd
Copy link
Copy Markdown
Member

lqd commented May 29, 2026

While trying to expand new solver testing in CI to keep it working, I've noticed that not only had we regressed building the stdlib (we knew that and now have CI to prevent that from happening before stabilization), we also regressed bootstrapping with the new solver enabled. That issue is still present on the main branch.

Building a stage 2 compiler with a stage 1 w/ new solver compiler, or RUSTFLAGS, will ICE very strangely while building regex_syntax (and I can't easily reproduce building that crate by itself...):

error: internal compiler error: compiler/rustc_ty_utils/src/sig_types.rs:114:13: Ctor(Variant, Fn) has not seen any uses of `walk_types` yet, ping oli-obk if you'd like any help
    --> ~/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/regex-syntax-0.8.8/src/ast/mod.rs:1134:5
     |
1134 |     Item(ClassSetItem),
     |     ^^^^


thread 'rustc' (1986053) panicked at compiler/rustc_ty_utils/src/sig_types.rs:114:13:

I don't really know what's going on, but it looks like weirdness w/ opaque types, during codegen. I've bisected that to 68f9143 from this PR so I wanted to let you and @lcnr know in case you hadn't noticed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jdonszelmann @rustbot @lcnr @rust-log-analyzer @JonathanBrouwer @lqd