add check for u8s in lit_to_const

[Kivooeo]

Fixes #131052

r? BoxyUwU

[rustbot]

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

[Kivooeo]

i also rewrote it from matches! to amazing and adoring if let guard feature

[BoxyUwU]

@bors r+ rollup

[bors]

📌 Commit c6b03ae has been approved by BoxyUwU

It is now in the queue for this repository.

[bors]

⌛ Testing commit c6b03ae with merge b49c7d7...

[bors]

☀️ Test successful - checks-actions
Approved by: BoxyUwU
Pushing b49c7d7 to main...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6e48b44 (parent) -> b49c7d7 (this PR)

Test differences

Show 5 test diffs

Stage 1

• [ui] tests/ui/const-generics/adt_const_params/byte-string-u8-validation.rs: [missing] -> pass (J0)

Stage 2

• [ui] tests/ui/const-generics/adt_const_params/byte-string-u8-validation.rs: [missing] -> pass (J1)

Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: x86_64-gnu-llvm-20-3, x86_64-gnu-llvm-21-3
• J1: aarch64-apple, aarch64-gnu, aarch64-gnu-llvm-20-1, aarch64-msvc-1, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-gnu, x86_64-gnu-debug, x86_64-gnu-gcc, x86_64-gnu-llvm-20, x86_64-gnu-llvm-20-2, x86_64-gnu-llvm-21-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b49c7d784e96216e1cb709824629f5d53bc73201 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. dist-aarch64-apple: 9357.3s -> 6393.4s (-31.7%)
2. x86_64-gnu-gcc: 3466.5s -> 2881.3s (-16.9%)
3. dist-x86_64-apple: 7531.4s -> 6279.4s (-16.6%)
4. dist-apple-various: 4265.6s -> 3575.1s (-16.2%)
5. pr-check-1: 1994.1s -> 1689.3s (-15.3%)
6. x86_64-gnu-llvm-21-2: 5746.6s -> 4870.3s (-15.2%)
7. aarch64-gnu: 7993.9s -> 6966.8s (-12.8%)
8. aarch64-gnu-llvm-20-2: 3055.7s -> 2696.4s (-11.8%)
9. x86_64-gnu-tools: 3650.6s -> 3225.6s (-11.6%)
10. aarch64-apple: 10088.4s -> 8920.4s (-11.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (b49c7d7): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary 1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.0%	[3.7%, 6.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.5%	[-4.5%, -4.5%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[3.0%, 3.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.5%	[-5.5%, -5.5%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 476.234s -> 476.873s (0.13%)
Artifact size: 390.86 MiB -> 390.81 MiB (-0.01%)