close
Skip to content

Derive Clone on Qdrant client#232

Merged
timvisee merged 2 commits into
devfrom
client-clone
Jul 15, 2025
Merged

Derive Clone on Qdrant client#232
timvisee merged 2 commits into
devfrom
client-clone

Conversation

@timvisee
Copy link
Copy Markdown
Member

@timvisee timvisee commented Jul 15, 2025

Fixes #229

Makes the client Clone, as it is common in other clients too.

It wraps the internal channel pool in an Arc.

Ideally we'd Arc the configuration too. But, it is exposed, and doing so will change the API interface people might already rely on. Just cloning the channel pool is probably a good enough compromise.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

This comment was marked as resolved.

@timvisee timvisee mentioned this pull request Jul 15, 2025
Copy link
Copy Markdown
Contributor

@coszio coszio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@timvisee timvisee merged commit 135d49c into dev Jul 15, 2025
2 checks passed
timvisee added a commit that referenced this pull request Jul 18, 2025
* Derive Clone on Qdrant client

* Reformat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants