Added list to core_args and added check for no-dedup. Program was ass…#288
Conversation
…uming these would be a part of the flag structure which breaks creation of a Program.run where a namespace is passed in.
|
Thanks for the catch. I assume I chopped up the core-args vs non-core-args stuff that way on purpose, so need to doublecheck the tickets & git history for it to be sure this won't cause another problem. But could've just been an oversight. |
|
The other solution to this is to not assume |
Revisiting this now that it's biting me in my dayjob use - I can see why I initially thought "don't expose Given that I hate unintuitive things and it's not super likely that non-Invoke users will be bothered by its existence...and of course given that having it in the non-core args is causing problems...I think probably OK to shuffle it around for now, as per this PR. |
|
Also, @sophacles made the same argument re: inclusion of list in this comment some time ago (re #276). So one less thing for that branch to handle whenever I get back to it (sob). |
|
We don't seem to cover the core bug this fixes in either the unit or integration test suites, sadface. Will whip one up. |
|
All set + tests + changelog, thanks again! |

…uming these would be a part of the flag structure which breaks creation of a Program.run where a namespace is passed in.
Consider the self contained python script ./foo
invoke.Programwould except because it assumesself.args.listwas defined. The list operation makes sense to be a part of core_args in this use case. After fixing thisinvoke.Programexcepts again assumingself.args['no-dedup']is defined.