Bugfix autoprint#175
Merged
Merged
Conversation
Member
|
Ah yea, I can see why the original implementation falls down on subcollections. Good catch! Re: Task vs Call, we might need to move the normalization of them higher up sometime (ideally they would already be Call objects once they get to the Executor) but that's not something to worry about for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes autoprint for tasks that are within a Collection.
The main problem is, that Tasks and Calls are mixed but treated all as tasks. Tests for equality work (because of the attribute delegation done by Call) as long as task and call have the same name.
The current fix is probably more of a workaround until the Task and Call handling has settled a bit.