apply Unix line endings for shell completion output for windows compat#3466
Merged
Merged
Conversation
038ef62 to
25c7b78
Compare
…patibility with Windows (pallets#3277)
25c7b78 to
a3321c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes shell completion installation on Windows where generated completion scripts could end up with CRLF line endings and fail to parse.
emits source and completions scripts through encoded bytes so the output stays LF-only and doesn't get converted to CRLF by Python.
Reimplements #3279
Fixes #3277