close
Skip to content

Add documentation for comparing json and ordered_json#3599

Merged
nlohmann merged 2 commits into
developfrom
issue3443_ordered_json_comparison
Jul 23, 2022
Merged

Add documentation for comparing json and ordered_json#3599
nlohmann merged 2 commits into
developfrom
issue3443_ordered_json_comparison

Conversation

@nlohmann
Copy link
Copy Markdown
Owner

@nlohmann nlohmann commented Jul 23, 2022

Closes #3443

@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Jul 23, 2022
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 23, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 8904546 on issue3443_ordered_json_comparison into e91686c on develop.

falbrechtskirchinger
falbrechtskirchinger suggested changes Jul 23, 2022
View reviewed changes
Comment thread docs/mkdocs/docs/api/basic_json/operator_eq.md Outdated
Comment thread docs/mkdocs/docs/api/basic_json/operator_eq.md Outdated
@nlohmann @falbrechtskirchinger
Apply suggestions from code review
8904546 
Co-authored-by: Florian Albrechtskirchinger <falbrechtskirchinger@gmail.com>
@nlohmann nlohmann added release item: 🔨 further change and removed review needed It would be great if someone could review the proposed changes. labels Jul 23, 2022
@nlohmann nlohmann self-assigned this Jul 23, 2022
@nlohmann nlohmann added this to the Release 3.11.0 milestone Jul 23, 2022
@nlohmann nlohmann merged commit 2d48a4d into develop Jul 23, 2022
@nlohmann nlohmann deleted the issue3443_ordered_json_comparison branch July 23, 2022 18:54
@akontsevich
Copy link
Copy Markdown

akontsevich commented Jul 24, 2022

I would extend the doc. Still not clear how to compare different JSON types. I converted one to another first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@falbrechtskirchinger falbrechtskirchinger falbrechtskirchinger requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nlohmann nlohmann

Labels

release item: 🔨 further change

Projects

None yet

Milestone

Release 3.11.0

Development

Successfully merging this pull request may close these issues.

ordered_json vs json types comparison

4 participants

@nlohmann @coveralls @akontsevich @falbrechtskirchinger