Fix TextmateSnippet clone method to correctly assign _children#295555
Merged
Conversation
Clone function incorrectly mutated the source object instead of assigning the clone children to the returning object.
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jriekenMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the TextmateSnippet.clone() method where the cloned children were incorrectly being assigned to the source object (this._children) instead of the newly created instance (ret._children). This bug would cause the original snippet to be mutated during cloning, leading to incorrect behavior.
Changes:
- Fixed
TextmateSnippet.clone()to correctly assign cloned children to the new instance instead of mutating the source object
jrieken
approved these changes
Apr 7, 2026
sandy081
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clone method incorrectly mutated the source object instead of assigning the cloned children to the returning object.