fix(lsp): Ensure file changes update lsp state#2267
Merged
Conversation
ospencer
approved these changes
Apr 2, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issues we were having with the lsp where it wouldn't update when you made changes, upon some investigation and a
git bisectI noticed that things stopped working in #2105 as we stopped reseting the compiler state when handling changes, this causes the parsetree cache to be hit and our changed module to never be reparsed.I wanted to add a regression test for this but It doesn't look like our lsp test suite is setup in a way that would make that easy.