close
Skip to content

[TINY] Skip SQL Server memory-optimized migration tests on Mac#37648

Merged
roji merged 1 commit into
dotnet:mainfrom
roji:SkipMemoryOptimizedOnMac
Feb 8, 2026
Merged

[TINY] Skip SQL Server memory-optimized migration tests on Mac#37648
roji merged 1 commit into
dotnet:mainfrom
roji:SkipMemoryOptimizedOnMac

Conversation

@roji
Copy link
Copy Markdown
Member

@roji roji commented Feb 8, 2026

See #37647

@roji roji requested a review from a team as a code owner February 8, 2026 10:15
Copilot AI review requested due to automatic review settings February 8, 2026 10:15
@roji roji enabled auto-merge (squash) February 8, 2026 10:15
Copilot AI reviewed Feb 8, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates SQL Server migrations functional tests to skip a subset of memory-optimized migration tests on macOS, working around the SQL Server crash described in #37647.

Changes:

  • Add PlatformSkipCondition(TestPlatform.Mac) to several memory-optimized migration tests in MigrationsSqlServerTest.
  • Add the required Microsoft.EntityFrameworkCore.TestUtilities.Xunit import for the new skip attribute.

Comment thread test/EFCore.SqlServer.FunctionalTests/Migrations/MigrationsSqlServerTest.cs Outdated
}

[ConditionalFact, SqlServerCondition(SqlServerCondition.SupportsMemoryOptimized)]
[PlatformSkipCondition(TestUtilities.Xunit.TestPlatform.Mac)] // TODO: see #37647
Copy link

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider setting SkipReason on PlatformSkipCondition (e.g. mentioning #37647 and the SQL Server crash under Rosetta). Otherwise the test runner will report the generic default skip reason and the inline // TODO comment won’t show up in CI results.

Suggested change
[PlatformSkipCondition(TestUtilities.Xunit.TestPlatform.Mac)] // TODO: see #37647
[PlatformSkipCondition(TestUtilities.Xunit.TestPlatform.Mac, SkipReason = "SQL Server crashes under Rosetta (#37647).")] // TODO: see #37647

Copilot uses AI. Check for mistakes.
Comment thread test/EFCore.SqlServer.FunctionalTests/Migrations/MigrationsSqlServerTest.cs Outdated
}

[ConditionalFact, SqlServerCondition(SqlServerCondition.SupportsMemoryOptimized)]
[PlatformSkipCondition(TestUtilities.Xunit.TestPlatform.Mac)] // TODO: see #37647
Copy link

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider setting SkipReason on PlatformSkipCondition (e.g. mentioning #37647 and the SQL Server crash under Rosetta). Otherwise the test runner will report the generic default skip reason and the inline // TODO comment won’t show up in CI results.

Suggested change
[PlatformSkipCondition(TestUtilities.Xunit.TestPlatform.Mac)] // TODO: see #37647
[PlatformSkipCondition(
TestUtilities.Xunit.TestPlatform.Mac,
SkipReason = "See #37647: SQL Server crash under Rosetta on macOS")]

Copilot uses AI. Check for mistakes.
Comment thread test/EFCore.SqlServer.FunctionalTests/Migrations/MigrationsSqlServerTest.cs Outdated
}

[ConditionalFact, SqlServerCondition(SqlServerCondition.SupportsMemoryOptimized)]
[PlatformSkipCondition(TestUtilities.Xunit.TestPlatform.Mac)] // TODO: see #37647
Copy link

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider setting SkipReason on PlatformSkipCondition (e.g. mentioning #37647 and the SQL Server crash under Rosetta). Otherwise the test runner will report the generic default skip reason and the inline // TODO comment won’t show up in CI results.

Suggested change
[PlatformSkipCondition(TestUtilities.Xunit.TestPlatform.Mac)] // TODO: see #37647
[PlatformSkipCondition(TestUtilities.Xunit.TestPlatform.Mac, SkipReason = "See #37647 - SQL Server crashes under Rosetta on macOS.")]

Copilot uses AI. Check for mistakes.
Comment thread test/EFCore.SqlServer.FunctionalTests/Migrations/MigrationsSqlServerTest.cs Outdated
@roji roji force-pushed the SkipMemoryOptimizedOnMac branch from cf8074e to ebf3c3d Compare February 8, 2026 10:37
@roji roji merged commit de736e7 into dotnet:main Feb 8, 2026
10 checks passed
@roji roji deleted the SkipMemoryOptimizedOnMac branch February 8, 2026 14:31
@dotnet-maestro dotnet-maestro Bot mentioned this pull request Feb 9, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@SamMonoRT SamMonoRT SamMonoRT approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roji @SamMonoRT