close
Skip to content

TINY: Add Deconstruct methods to {Vector,FullText}SearchResults#37644

Merged
roji merged 2 commits into
dotnet:mainfrom
roji:Deconstruct
Feb 7, 2026
Merged

TINY: Add Deconstruct methods to {Vector,FullText}SearchResults#37644
roji merged 2 commits into
dotnet:mainfrom
roji:Deconstruct

Conversation

@roji
Copy link
Copy Markdown
Member

@roji roji commented Feb 7, 2026

No description provided.

@roji roji requested a review from a team as a code owner February 7, 2026 07:50
Copilot AI review requested due to automatic review settings February 7, 2026 07:50
@roji roji enabled auto-merge (squash) February 7, 2026 07:51
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Deconstruct methods to the SQL Server extension result structs so callers can use tuple deconstruction syntax when consuming vector and full-text search results.

Changes:

  • Add Deconstruct(out T value, out double distance) to VectorSearchResult<T>.
  • Add Deconstruct(out TKey key, out int rank) to FullTextSearchResult<TKey>.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/EFCore.SqlServer/Extensions/VectorSearchResult.cs Adds deconstruction support for (Value, Distance) consumers.
src/EFCore.SqlServer/Extensions/FullTextSearchResult.cs Adds deconstruction support for (Key, Rank) consumers.

Comment thread src/EFCore.SqlServer/Extensions/VectorSearchResult.cs Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 7, 2026 08:12
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@roji roji disabled auto-merge February 7, 2026 20:43
@roji roji merged commit 82ee1b8 into dotnet:main Feb 7, 2026
13 of 16 checks passed
@roji roji deleted the Deconstruct branch February 7, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants