Add the verbose output of the internal call to dotnet in dotnet-ef#37643
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances dotnet-ef diagnostics by adding verbose logging around the internal dotnet msbuild invocation used to extract project metadata.
Changes:
- Add a new localized resource (
RunningCommand) for verbose command execution messages. - Emit verbose output for the
dotnet msbuildmetadata call inProject.FromFile, including the captured output. - Regenerate/update the
Resources.Designer.csto reflect.resxchanges.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/dotnet-ef/Properties/Resources.resx | Adds RunningCommand string resource (and reorders some existing entries). |
| src/dotnet-ef/Properties/Resources.Designer.cs | Updates strongly-typed resource accessors for the .resx changes. |
| src/dotnet-ef/Project.cs | Adds verbose logging for the internal dotnet call and its output during project metadata retrieval. |
Files not reviewed (1)
- src/dotnet-ef/Properties/Resources.Designer.cs: Language not supported
roji
approved these changes
Feb 7, 2026
Contributor
|
@AndriySvyryd I've opened a new pull request, #37658, to work on those changes. Once the pull request is ready, I'll request review from you. |
6035d6f to
8d46ce1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.