close
Skip to content

Use Wix5 in SharedFx/Targeting Pack .msi's#65637

Merged
wtgodbe merged 8 commits into
mainfrom
wtgodbe/Wix5Again
Mar 4, 2026
Merged

Use Wix5 in SharedFx/Targeting Pack .msi's#65637
wtgodbe merged 8 commits into
mainfrom
wtgodbe/Wix5Again

Conversation

@wtgodbe
Copy link
Copy Markdown
Member

@wtgodbe wtgodbe commented Mar 3, 2026

During the Wix5 upgrade, we updated the bundle to build with Wx5, but not the actual SharedFx/Targeting Pack .msi's that we re-distribute. This should fix the issue. Need to backport this to 10.0 as well

@wtgodbe wtgodbe requested review from Copilot and joeloff March 3, 2026 18:56
@github-actions github-actions Bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 3, 2026
This was referenced Mar 3, 2026
Open
Open
Copilot AI reviewed Mar 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@wtgodbe wtgodbe requested a review from Copilot March 3, 2026 20:24
Copilot AI reviewed Mar 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Comment thread src/Framework/App.Runtime/bundle/aspnetcore-runtime-bundle.bundleproj
Comment thread src/Framework/Directory.Build.targets Outdated
Comment thread src/Framework/Directory.Build.targets Outdated
Comment thread src/Framework/Directory.Build.targets Outdated
wtgodbe and others added 3 commits March 3, 2026 12:33
@wtgodbe
Apply suggestions from code review
0755266 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@wtgodbe
Remove PrivateAssets from PackageReference
0b77d15
@wtgodbe
Fixup
fd11f3f
@wtgodbe
Copy link
Copy Markdown
Member Author

wtgodbe commented Mar 4, 2026

Local testing confirms this works

@wtgodbe wtgodbe merged commit 5c76285 into main Mar 4, 2026
25 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/Wix5Again branch March 4, 2026 17:23
@wtgodbe
Copy link
Copy Markdown
Member Author

wtgodbe commented Mar 4, 2026

/backport to release/10.0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2026

Started backporting to release/10.0 (link to workflow run)

@dotnet-policy-service dotnet-policy-service Bot added this to the 11.0-preview3 milestone Mar 4, 2026
@github-actions github-actions Bot mentioned this pull request Mar 4, 2026
Merged
11 tasks
@dotnet-maestro dotnet-maestro Bot mentioned this pull request Mar 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@joeloff joeloff joeloff approved these changes

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

11.0-preview3

Development

Successfully merging this pull request may close these issues.

3 participants

@wtgodbe @joeloff