Blazor united initial startup apis for registering pages#46996
Conversation
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> | ||
| <Description>Server side rendering for ASP.NET Core Components.</Description> |
There was a problem hiding this comment.
Why include a $(Description) if this isn't going into its own package❔
There was a problem hiding this comment.
This is following the template from other projects in this folder. It's fine to leave it even if we do not need it.
| @@ -0,0 +1,10 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
I'm sure this project will be successful across the board 😁:
There was a problem hiding this comment.
Are you implying there is something wrong?
I copied the code from another test project
There was a problem hiding this comment.
I think he's just remarking that it's a completely empty test project so it's always going to pass :)
There was a problem hiding this comment.
I think he's just remarking that it's a completely empty test project so it's always going to pass :)
exactly
There was a problem hiding this comment.
It has a couple of tests now 😄.
This PR is only adding all the scaffold for the things we need.
…rver Side Rendering components
4a490b3 to
9239fb9
Compare
|
@wtgodbe do you have any idea why the shared framework tests fail? I tried to poke around, but I am not too familiar to how the SharedFx builds and can't find a way to solve it. |
| "Microsoft.AspNetCore.Authorization.Policy", | ||
| "Microsoft.AspNetCore.Components", | ||
| "Microsoft.AspNetCore.Components.Authorization", | ||
| "Microsoft.AspNetCore.Components.Endpoints", |
There was a problem hiding this comment.
@javiercn Add this to ListedTargetingPackAssemblies below as well (around line 177)
SteveSandersonMS
left a comment
There was a problem hiding this comment.
@javiercn So far this all looks perfect to me.
Do you plan to add an E2E test showing that your new endpoint gets hit? It doesn't necessarily have to use a browser - it could just do an HttpClient request to an E2E test app, like we do for the other prerendering tests. But no worries if you prefer that to be handled in a separate PR.
|
@SteveSandersonMS let's handle that one separately, as we start getting into more details. Need to check the approach we use in MVC. |
Brings in the initial implementation for
Components.Endpoints.Note that the goal of this PR is to focus on providing the initial structure and not a proper implementation of any of the concepts. There are links in comments pointing to issues that provide more context and details.
I have stopped at the point where we have a sample that is able to discover components in the app and render a static page. We will be filling in the gaps in comments that are captured in other issues.