Avoid redundant Assembly.Load call in DefaultAssemblyPartDiscoveryProvider

[CoskunSunali]

I don't know if I am overlooking but if I am right, the assemblies are being loaded twice during the discovery of assembly parts.

Please see: https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.Core/Internal/DefaultAssemblyPartDiscoveryProvider.cs#L37-L38

[pranavkm]

Yup, would you like to send a PR to fix it?

[CoskunSunali]

Sure, will do that asap.

[CoskunSunali]

Created the PR. This was my first-ever contribution. Please kindly let me know if I was able to follow the contribution/PR guidelines correctly.

[Eilon]

BTW I doubt the assembly is actually loaded twice because I'd think everything is cached by the CLR. But still, good to clean this up!

[davidfowl]

Yep it is cached

[CoskunSunali]

If it is being cached (thankfully!) the title of the issue might be misleading, as well as the PR's title. Is it a good idea to change it?

[pranavkm]

It's still good to re-use the variable like you did. I tweaked the title a bit to reflect this. Thanks for the PR, your change was merged in d2430f0