fix: make title and term suggestion UI reactive#584
Merged
dkotter merged 1 commit intoMay 19, 2026
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
dkotter
approved these changes
May 19, 2026
simison
pushed a commit
to simison/ai
that referenced
this pull request
May 25, 2026
Fixed - Make title generation and content classification UI react to current editor state. Co-authored-by: Malayt04 <malaytiwari@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What?
Closes #579
Fixes two stale editor state issues in the AI experiment UI:
Why?
Both issues came from reading editor state with
select()directly in component render paths instead of subscribing reactively withuseSelect().In title generation, the toolbar could keep showing
GenerateorRegeneratebased on the title value from the initial render, even after the title changed.In content classification, the suggest button could remain disabled or enabled based on stale content, and the generate action could submit older content instead of the latest editor state.
How?
This PR updates the affected components and hook to use reactive editor store reads where UI state depends on live editor data.
src/experiments/title-generation/components/TitleToolbar.tsxselect()reads forpostIdandtitlewithuseSelect()src/experiments/content-classification/components/useContentClassification.tsselect()reads forpostIdandcontentwithuseSelect()src/experiments/content-classification/components/SuggestionPanel.tsxuseSelect()for reactive store usage consistencyUse of AI Tools
AI assistance: Yes
Tool(s): Codex
Model(s): GPT-5
Used for: Implementing the component fixes
Testing Instructions
Title Generationexperiment.Generate.Regenerate.Generate.Content Classificationexperiment.TagsorCategoriespanel in the post editor.Suggest TagsorSuggest Categories, and verify the generated request uses the latest editor content.Screenshots or screencast
Title generation
Before
Title-before.mov
After
Title-after.mov
Content classification suggestions
Before
Suggest-terms-after.mov
After
Suggest-terms-before.mov
Changelog Entry