close
Skip to content

fix(a11y): improve focus visibility on suggested terms#580

Merged
dkotter merged 2 commits into
WordPress:developfrom
CookieDarb:fix/suggested-term-focus-style
May 19, 2026
Merged

fix(a11y): improve focus visibility on suggested terms#580
dkotter merged 2 commits into
WordPress:developfrom
CookieDarb:fix/suggested-term-focus-style

Conversation

@CookieDarb
Copy link
Copy Markdown
Contributor

@CookieDarb CookieDarb commented May 19, 2026

What?

Closes #570

This PR improves the focus visibility of the suggested term and dismiss buttons inside the Suggested Terms taxonomy pills for keyboard users.

Why?

Previously, keyboard users could not discern which button within a suggested taxonomy pill had focus. This improves accessibility and focus clarity.

How?

Added explicit focus styles to the suggested-term action buttons so the focused state is clearly visible, using existing WordPress admin theme variables for consistency.

Use of AI Tools

AI assistance: Yes
Tool(s): Antigravity
Model(s): Gemini 3.1 Pro, Gemini 3 Flash
Used for: Suggesting and implementing the fix. Final implementation was reviewed and edited by me.

Testing Instructions

  1. Open a post with content (about 150+ words).
  2. Click “Suggest Categories” to show suggested terms.
  3. Use the keyboard (Tab/Shift+Tab) to focus the buttons.

Screenshots or screencast

Add button is focused:
Add_Button_Focused

Dismiss button is focused:
Dismiss_Button_Focused

Changelog Entry

Fixed - Improve keyboard focus visibility for suggested term actions in content classification.

Open WordPress Playground Preview

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.41%. Comparing base (1704050) to head (a17075c).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #580   +/-   ##
==========================================
  Coverage      71.41%   71.41%           
  Complexity      1158     1158           
==========================================
  Files             67       67           
  Lines           5586     5586           
==========================================
  Hits            3989     3989           
  Misses          1597     1597           
Flag Coverage Δ
unit 71.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CookieDarb CookieDarb marked this pull request as ready for review May 19, 2026 10:30
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: CookieDarb <sakshamsharma5@git.wordpress.org>
Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Copy Markdown
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected/described, thanks!

@dkotter dkotter added this to the 1.0.0 milestone May 19, 2026
@dkotter dkotter mentioned this pull request May 19, 2026
42 tasks
@dkotter dkotter merged commit 6734c43 into WordPress:develop May 19, 2026
19 checks passed
simison pushed a commit to simison/ai that referenced this pull request May 25, 2026
Fixed - Improve keyboard focus visibility for suggested term actions in content classification.

Co-authored-by: CookieDarb <sakshamsharma5@git.wordpress.org>
Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

a11y: The focus style of the suggested term is incorrect

3 participants