close
Skip to content

Settings: use _n() instead of __() for numerical updates#491

Merged
dkotter merged 2 commits into
WordPress:developfrom
simison:fix/settings-number
Apr 30, 2026
Merged

Settings: use _n() instead of __() for numerical updates#491
dkotter merged 2 commits into
WordPress:developfrom
simison:fix/settings-number

Conversation

@simison
Copy link
Copy Markdown
Member

@simison simison commented Apr 30, 2026

What?

Closes

Use _n() for translations with numerical values to be able to translate to languages like Russian, where singular/plural isn't used like in English.

Why?

How?

Use of AI Tools

AI assistance: Yes
Tool(s): Cursor

Testing Instructions

Snackbar notices continue work
image

Screenshots or screencast

No difference in visuals.

Changelog Entry

Added - New feature.
Changed - Existing functionality.
Deprecated - Soon-to-be removed feature.
Removed - Feature.
Fixed - Bug fix.
Security - Vulnerability.
Development Update - Development related updates.

Open WordPress Playground Preview

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: simison <simison@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.06%. Comparing base (c9dfaa6) to head (19897b5).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #491      +/-   ##
=============================================
+ Coverage      68.50%   69.06%   +0.55%     
  Complexity       957      957              
=============================================
  Files             60       60              
  Lines           4861     4512     -349     
=============================================
- Hits            3330     3116     -214     
+ Misses          1531     1396     -135     
Flag Coverage Δ
unit 69.06% <ø> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dkotter dkotter added this to the 0.9.0 milestone Apr 30, 2026
@dkotter dkotter merged commit a558eed into WordPress:develop Apr 30, 2026
18 checks passed
simison added a commit to simison/ai that referenced this pull request May 25, 2026
Co-authored-by: simison <simison@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants