Repository navigation
Conversation
ace-ify
requested review from
abeldantas,
agent-runner353,
amaudruz,
christian-mcdermott,
lbangalosbt,
massimo-sandboxaq,
niall-sandboxaq,
petr-sandbox,
raullopez-sandbox and
simonflk-sb
as code owners
November 7, 2026 08:09
|
All contributors have signed the CLA. ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
ace-ify
force-pushed
the
feat/803-safe-tool-input-output
branch
from
November 7, 2026 09:24
9c88970 to
175f058
Compare
5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What this changes
Shows tool call details (inputs and outputs) in collaboration channels safely with secret redaction, size bounding, and room-level disclosure controls:
switch_core.bridges.collaboration.session.redaction): Masks sensitive credentials including PEM private keys, provider API keys (OpenAI, Anthropic, GitHub, Slack, AWS, Google), JWTs, Bearer tokens, database connection string passwords, MCP/HTTP Authorization headers, and environment variable secret assignments before channel rendering.RoomStore): Supportstool_detail_offroom metadata toggle (tool_detail_enabled_in,tool_detail_enabled,set_tool_detail_enabled). Stored execution detail is preserved in DB and stripped on read/render when the toggle is off._plan_task,_plan) and neutral/Mattermost (activity_log,_log_line) collaboration session renderers.Closes #803
How it was tested
tests/switch_core/bridges/collaboration/test_safe_tool_redaction.py(10 tests) covering PEM keys, provider tokens, DB URLs, headers, env secrets, and character limit truncation.tests/switch_core/bridges/collaboration/test_safe_tool_rendering.py(5 tests) verifying Slack card detail redaction, neutral activity log masking, and room toggle state behavior.test_session_slack_requests.py).ruff checkandruff format.