ForwardingRule Target fix - #7371
Merged
ldanielmadariaga merged 3 commits intoMay 21, 2026
Merged
Conversation
suwandim
marked this pull request as ready for review
April 8, 2026 22:38
ldanielmadariaga
approved these changes
May 21, 2026
Collaborator
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldanielmadariaga The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
via the queue into
GoogleCloudPlatform:master
with commit May 21, 2026
ed8b2ae
169 checks passed
This was referenced May 21, 2026
This was referenced May 21, 2026
codebot-robot
pushed a commit
to codebot-robot/k8s-config-connector
that referenced
this pull request
May 21, 2026
…form#8528) Update the go client with `make generate-go-client` this is a follow up to PR GoogleCloudPlatform#7371 which passed all presubmit checks but was still missing running this command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BRIEF Change description
Fixes #7339
WHY do we need this change?
Special notes for your reviewer:
Does this PR add something which needs to be 'release noted'?
Additional documentation e.g., references, usage docs, etc.:
Intended Milestone
Please indicate the intended milestone.
Tests you have done
make ready-prto ensure this PR is ready for review.