Fix ComputeBackendService with INTERNAL_SELF_MANAGED loadBalancingScheme - #10414
Merged
Merged
Conversation
gemmahou
previously approved these changes
Jun 17, 2026
Collaborator
|
Test against realGCP and the resource with |
Collaborator
|
Please fix the failed ci-presubmit / tests-e2e-fixtures-compute (pull_request) job. |
… loadBalancingScheme
Prevent the automatic injection of `subsetting: { policy: "NONE" }` for regional backend services with `INTERNAL_SELF_MANAGED` load balancing scheme. This is because subsetting is not supported for Traffic Director / INTERNAL_SELF_MANAGED scheme.
Fixes GoogleCloudPlatform#10402
auto-merge was automatically disabled
June 17, 2026 22:44
Head branch was pushed to by a user without write access
codebot-robot
force-pushed
the
issue_10402
branch
from
June 17, 2026 22:44
24874d5 to
0ac27d5
Compare
gemmahou
enabled auto-merge
June 17, 2026 23:23
gemmahou
approved these changes
Jun 17, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gemmahou The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jun 18, 2026
Merged
via the queue into
GoogleCloudPlatform:master
with commit Jun 18, 2026
209cac7
184 of 355 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent the automatic injection of
subsetting: { policy: "NONE" }for regional backend services withINTERNAL_SELF_MANAGEDload balancing scheme. This occurs because Traffic Director /INTERNAL_SELF_MANAGEDschemes do not support subsetting, causing GCP API server validation to fail during creation.I have verified the fix with a new E2E test case under
pkg/test/resourcefixture/testdata/basic/compute/v1beta1/computebackendservice/regionalcomputebackendservicetdthat runs successfully against MockGCP.Fixes #10402