close
Skip to content

Implement Simple Analytics#212

Merged
iamdharmesh merged 104 commits into
developfrom
feature/simple-analytics
Jun 3, 2026
Merged

Implement Simple Analytics#212
iamdharmesh merged 104 commits into
developfrom
feature/simple-analytics

Conversation

@iamdharmesh
Copy link
Copy Markdown
Collaborator

@iamdharmesh iamdharmesh commented May 13, 2026

Description of the Change

Merged PRs:

Closes #189

How to test the Change

N/A

Changelog Entry

Added -

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

alaca and others added 30 commits March 20, 2026 10:46
- Range selector improvements
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Dharmesh Patel <dspatel44@gmail.com>
Co-authored-by: Dharmesh Patel <dspatel44@gmail.com>
@iamdharmesh iamdharmesh assigned alaca and unassigned iamdharmesh May 13, 2026
@ankitguptaindia
Copy link
Copy Markdown
Collaborator

ankitguptaindia commented May 26, 2026

QA Status: Needs feedback ⚠️

Hi @iamdharmesh I tested this PR via feature/simple-analytics by creating a build zip from GH action https://github.com/mailchimp/wordpress/actions/runs/26459085882 (zip attached) and noticed that the graphs are not loading in the Analytics page.

I tested on three different fresh new sites and faced the same result.

Details

Site:1

image

Site:2

Screenshot 2026-05-26 at 9 46 34 PM

Site:3

Screenshot 2026-05-26 at 9 46 58 PM

Here are the steps I am following:

Recording.1849.mp4

cc: @vikrampm1

@iamdharmesh
Copy link
Copy Markdown
Collaborator Author

Hi @ankitguptaindia, Thanks for the comment.

Hi @iamdharmesh I tested this PR via feature/simple-analytics by creating a build zip from GH action https://github.com/mailchimp/wordpress/actions/runs/26459085882 (zip attached) and noticed that the graphs are not loading in the Analytics page.

It seems you created zip based of feature/data-layer-and-form-event-tracking branch. Could you please check once? Thanks.

image

@iamdharmesh iamdharmesh marked this pull request as ready for review May 26, 2026 16:23
@github-actions github-actions Bot added the needs:code-review This requires code review. label May 26, 2026
@ankitguptaindia
Copy link
Copy Markdown
Collaborator

@iamdharmesh Thanks for the quick reply, I just checked, and yes, I accidentally copied wrong branch name while creating the build.

Graphs loads correctly with correct branch:

image

@github-actions github-actions Bot added the needs:refresh This requires a refreshed PR to resolve. label May 26, 2026
@github-actions github-actions Bot removed the needs:refresh This requires a refreshed PR to resolve. label May 26, 2026
@builtbytay
Copy link
Copy Markdown
Collaborator

builtbytay commented May 26, 2026

@iamdharmesh @alaca

UAT Feedback — Mailchimp SAP Integration


1. Error Handling QA

Video reference: Internal Slack File

Issue: Error state is unclear to the user and the CTA button has no action.

Action required: Audit all possible error states end-to-end. For each, confirm:

  • Error message is human-readable and explains the cause
  • CTA button is present only when there is a user-actionable resolution
  • CTA correctly resolves or routes to resolution

Known error states to test (expand if additional states exist):

Error User-Resolvable? Expected Behavior
API not connected Yes Clear message + "Reconnect Mailchimp Account" CTA
Database error No Clear message explaining issue is internal; no CTA button should render

⚠️ If additional error states exist beyond these two, document them and apply the same resolution logic.


2. Copy Changes — List Performance Over Time

Location Current Updated
Section label Form Activity List Activity
Subtitle/description Views, submissions, and conversion rate over time All form views, submissions, and conversion rate over time

3. Issue Prevention — Plugin Version / DB Upgrade Edge Case

Context: During UAT setup, installing a previous plugin version followed by replacing it with the UAT build caused the database upgrade script not to run, resulting in a broken/unusable analytics state. This was triggered by an accidental install sequence (wrong version first, then deleted and replaced) — not a standard user flow.

Confirmed: Normal users won't hit this through typical installation. However, the DB table creation script is currently gated behind a version check, which makes it fragile in non-standard install sequences.

Action required: Move the DB create/upgrade script out of the version check so it runs reliably regardless of install order. Dharmesh to confirm approach with Ante.

@iamdharmesh iamdharmesh merged commit 1737d78 into develop Jun 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs:code-review This requires code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Simple Analytics

4 participants