fix: add inline class to connector approval admin notice for proper l…#628
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #628 +/- ##
=============================================
+ Coverage 74.01% 74.45% +0.43%
- Complexity 1738 1740 +2
=============================================
Files 85 85
Lines 7517 7521 +4
=============================================
+ Hits 5564 5600 +36
+ Misses 1953 1921 -32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I've updated the implementation to scope the .inline class conditionally so it is only applied on the Request Logs page. On other screens, the default relocation behavior remains completely untouched. |
…on the Request Log page to make the notice look better



What?
Closes: #596
Fixes the connector approval notice overlapping the header on the AI Request Logs screen when both the Connector Approvals and AI Request Logging experiments are enabled.
Why?
WordPress Core's
common.jsautomatically relocates.noticeelements to after the firsth1in.wrap. The@wordpress/admin-uiPagecomponent renders itsh1inside a flex header container, so the notice ends up as an inline flex child in the header row.How?
Added the
inlineclass to the notice output inAdmin_Notice::render(). WordPress Core'scommon.jsexplicitly skips elements with theinlineclass when relocating notices, so the notice stays in its natural output position instead of being moved into the flex header.Use of AI Tools
AI assistance: Yes
Tool(s): Antigravity
Used for: Deciding most optimal approach
Screenshots or screencast
Before
After
Changelog Entry