Fixed documentation comment ID handling for dynamic and tuples#48359
Merged
Conversation
333fred
reviewed
Oct 6, 2020
333fred
reviewed
Oct 6, 2020
Member
|
Done review pass (commit 1) |
Member
Author
|
@333fred I have addressed your comments and also added a test for |
333fred
reviewed
Oct 7, 2020
333fred
approved these changes
Oct 8, 2020
Member
333fred
left a comment
There was a problem hiding this comment.
LGTM. @dotnet/roslyn-compiler for a second review.
Member
|
@dotnet/roslyn-compiler for a second review of this community PR. |
cston
approved these changes
Oct 9, 2020
Member
Author
|
I believe this should also fix the recently opened #48495, so I have added a test for that and modified "fixes" accordingly. |
Youssef1313
reviewed
Oct 10, 2020
Member
|
Thanks @svick! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34839.
Fixes #48495.
Previously,
DocumentationCommentId.CreateDeclarationIdbehaved correctly for named and unnamed tuples, but not fordynamic. AndDocumentationCommentId.GetSymbolsForDeclarationIdonly behaved correctly for unnamed tuples, but not for named tuples ordynamic.This PR fixes all the cases that didn't behave correctly so that the documentation comment ID represents CLR signature of the member (i.e.
System.ObjectfordynamicandSystem.ValueTuplefor tuples).