close
Skip to content

Fix typo 'bar]' to 'bar' in RunService samples and test fixtures#6693

Merged
maqiuyujoyce merged 1 commit into
GoogleCloudPlatform:masterfrom
eugenenuke:fix-runservice-typo
Mar 23, 2026
Merged

Fix typo 'bar]' to 'bar' in RunService samples and test fixtures#6693
maqiuyujoyce merged 1 commit into
GoogleCloudPlatform:masterfrom
eugenenuke:fix-runservice-typo

Conversation

@eugenenuke
Copy link
Copy Markdown
Contributor

BRIEF Change description

This PR corrects a pervasive typo in RunService environment variable values, where bar] was used instead of bar.

The fix updates:

  • Active KCC samples in config/samples/resources/runservice and config/samples/resources/computeregionnetworkendpointgroup.
  • Integration test fixtures in pkg/test/resourcefixture/testdata/basic/.
  • Generated documentation in scripts/generate-google3-docs/.

WHY do we need this change?

To ensure documentation accuracy and clean up confusing sample values for users.

Special notes for your reviewer:

Golden logs (_http.log) were updated using mockgcp to reflect the change in the requested environment variable values.

Does this PR add something which needs to be 'release noted'?

NONE

Additional documentation e.g., references, usage docs, etc.:

NONE

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.
  • Verified passing tests for runservicebasic and cloudruncomputeregionnetworkendpointgroup against mockgcp.

@eugenenuke
Copy link
Copy Markdown
Contributor Author

/cc @gemmahou

@google-oss-prow google-oss-prow Bot requested a review from gemmahou February 23, 2026 16:05
@gemmahou
Copy link
Copy Markdown
Collaborator

I noticed that there are lots of unrelated doc updates in this PR, due to the fact that our g3 reference doc is out-dated, and "generate-google3-docs" updates them here.

cc @xiaoweim, @maqiuyujoyce

@eugenenuke
Copy link
Copy Markdown
Contributor Author

Do you want me to split the PR in two? E.g. a typo fix + a doc update?

Another CI test can be added to make sure that the docs are always up-to-date. I can check if I can handle that in a separate PR. WDYT?

@gemmahou
Copy link
Copy Markdown
Collaborator

Do you want me to split the PR in two? E.g. a typo fix + a doc update?

Another CI test can be added to make sure that the docs are always up-to-date. I can check if I can handle that in a separate PR. WDYT?

I believe @xiaoweim is taking care of the doc updates. Can we hold this PR until that's done?

@xiaoweim
Copy link
Copy Markdown
Collaborator

xiaoweim commented Feb 24, 2026

Yes, this is the PR #6856 6856 to update the reference documents.

@gemmahou
Copy link
Copy Markdown
Collaborator

gemmahou commented Mar 19, 2026

Can we rebase with master and resolve the merge conflict since #5856 has been merged?

@eugenenuke eugenenuke force-pushed the fix-runservice-typo branch from 34b0972 to 1cadc35 Compare March 23, 2026 15:09
@eugenenuke
Copy link
Copy Markdown
Contributor Author

Can we rebase with master and resolve the merge conflict since #5856 has been merged?

done

@gemmahou
Copy link
Copy Markdown
Collaborator

/lgtm

@eugenenuke
Copy link
Copy Markdown
Contributor Author

/assign @maqiuyujoyce

Copy link
Copy Markdown
Collaborator

@maqiuyujoyce maqiuyujoyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@maqiuyujoyce maqiuyujoyce added this pull request to the merge queue Mar 23, 2026
@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gemmahou, maqiuyujoyce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Merged via the queue into GoogleCloudPlatform:master with commit 46d7240 Mar 23, 2026
166 checks passed
@cheftako cheftako added this to the 1.148 milestone Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants