Fix typo 'bar]' to 'bar' in RunService samples and test fixtures#6693
Conversation
|
/cc @gemmahou |
|
I noticed that there are lots of unrelated doc updates in this PR, due to the fact that our g3 reference doc is out-dated, and "generate-google3-docs" updates them here. |
|
Do you want me to split the PR in two? E.g. a typo fix + a doc update? Another CI test can be added to make sure that the docs are always up-to-date. I can check if I can handle that in a separate PR. WDYT? |
I believe @xiaoweim is taking care of the doc updates. Can we hold this PR until that's done? |
|
Yes, this is the PR #6856 6856 to update the reference documents. |
|
Can we rebase with master and resolve the merge conflict since #5856 has been merged? |
34b0972 to
1cadc35
Compare
done |
|
/lgtm |
|
/assign @maqiuyujoyce |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gemmahou, maqiuyujoyce The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
46d7240

BRIEF Change description
This PR corrects a pervasive typo in
RunServiceenvironment variable values, wherebar]was used instead ofbar.The fix updates:
config/samples/resources/runserviceandconfig/samples/resources/computeregionnetworkendpointgroup.pkg/test/resourcefixture/testdata/basic/.scripts/generate-google3-docs/.WHY do we need this change?
To ensure documentation accuracy and clean up confusing sample values for users.
Special notes for your reviewer:
Golden logs (
_http.log) were updated usingmockgcpto reflect the change in the requested environment variable values.Does this PR add something which needs to be 'release noted'?
NONE
Additional documentation e.g., references, usage docs, etc.:
NONE
Tests you have done
make ready-prto ensure this PR is ready for review.runservicebasicandcloudruncomputeregionnetworkendpointgroupagainstmockgcp.