Migrate patrons_follows_json endpoint to FastAPI

[Sanket17052006]

Closes #

This PR migrates the patrons_follows_json web.py handler to FastAPI.

Technical

• Add GET /people/{username}/follows.json FastAPI handler
• Add POST /people/{username}/follows.json FastAPI handler
• Add FollowEntry Pydantic response model.
• Mark legacy web.py handler as @deprecated("migrated to fastapi")
• Add tests.

Testing

Test file : docker compose run --rm home pytest openlibrary/tests/fastapi/test_follows.py -v

• 1. Login

curl -s -c /tmp/cookies.txt -X POST "http://localhost:8080/account/login.json" \
  -H "Content-Type: application/json" \
  -d '{"username":"openlibrary","password":"openlibrary"}'

• 2. GET authenticated → 200 + data

curl -s -b /tmp/cookies.txt "http://localhost:18080/people/openlibrary/follows.json"

• 3. POST subscribe → 303

- curl -s -b /tmp/cookies.txt -X POST "http://localhost:18080/people/openlibrary/follows.json" \
   -d "publisher=openlibrary&state=0&redir_url=/" -w "%{http_code}"

• 4. POST unsubscribe → 303

curl -s -b /tmp/cookies.txt -X POST "http://localhost:18080/people/openlibrary/follows.json" \
-d "publisher=openlibrary&state=1&redir_url=/" -w "%{http_code}"

• 5. GET unauthenticated → 303 to login

curl -s "http://localhost:18080/people/openlibrary/follows.json" \
 -w "HTTP %{http_code} -> %{redirect_url}"

• 6. POST nonexistent publisher → 404

curl -s -b /tmp/cookies.txt -X POST "http://localhost:18080/people/openlibrary/follows.json" \
 -d "publisher=fakepublisher&state=0&redir_url=/" -w "HTTP %{http_code}"

• 7. GET wrong user → 303 to login

curl -s -b /tmp/cookies.txt "http://localhost:18080/people/otheruser/follows.json" \
  -w "HTTP %{http_code} -> %{redirect_url}"

Screenshot

N/A

Stakeholders

@RayBB

[mekarpeles]

Thanks for the PR, @Sanket17052006.

🤖 Copilot has been assigned for an initial review.

There are currently 76 open non-draft PRs ahead of yours in the queue. A reviewer has not yet been assigned to this PR.

Possible improvements for this PR

• Link a GitHub issue — the PR body has Closes # with no issue number filled in. If this migration was tracked in a GitHub issue, please add the number. If no issue exists, consider opening one so the work can be triaged and assigned.

PR triage checklist (maintainers / Pam)

• PR description — not empty; explains what the change does and how to verify it
• References an issue — PR body contains a #NNN reference
  • Linked issue is triaged — has a Priority: * label (not just Needs: Triage)
  • Linked issue is assigned — has at least one assignee
• Commit history clean — no WIP/fixup/conflict noise; commit messages are meaningful
• CI passing — no failing check-runs
• Test cases present — if the change touches substantive logic, test coverage exists or is explained
• Proof of testing — PR body includes a description of what was tested, a screenshot, or a video

Note

This comment was automatically generated by Pam, Open Library's Project AI Manager, on behalf of @mekarpeles. Pam is designed to provide status visibility, perform basic project management functions and relevant codebase research, and provide actionable feedback so contributors aren't left waiting.

[Copilot]

Pull request overview

This PR migrates the legacy patrons_follows_json web.py handler to FastAPI by introducing GET/POST /people/{username}/follows.json, adding a FollowEntry response model, deprecating the old handler, and adding FastAPI tests to cover the new behavior.

Changes:

• Added FastAPI GET /people/{username}/follows.json to return a user’s follow list (or redirect to login).
• Added FastAPI POST /people/{username}/follows.json to subscribe/unsubscribe (or redirect to login / 404 on missing publisher).
• Added a new FastAPI test suite for the follows endpoints and marked the legacy web.py handler as deprecated.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
openlibrary/fastapi/internal/api.py	Adds FollowEntry plus new GET/POST follows endpoints in FastAPI.
openlibrary/plugins/openlibrary/api.py	Marks the legacy patrons_follows_json web.py handler as deprecated.
openlibrary/tests/fastapi/test_follows.py	Adds FastAPI tests for GET/POST follows behavior, redirects, and 404 handling.

[RayBB]

@Shikhar-395 could you please test and review this?

[Shikhar-395]

Verdict: Needs changes for one routing issue.

Finding

This PR adds the FastAPI handlers for /people/{username}/follows.json, but does not add the legacy route pattern to DEPRECATED_PATHS.

openlibrary/code.py only swaps deprecated web.py routes to DeprecatedJSONEndpointHandler for paths listed in openlibrary/plugins/openlibrary/deprecated_handler.py. Without this entry, /people/<username>/follows.json through legacy routing will continue hitting the old web.py handler instead of proxying to FastAPI.

Please add:

(r"(/people/[^/]+)/follows", "json"),

[Sanket17052006]

Hey @Shikhar-395, I've addressed the review and added the legacy route pattern to DEPRECATED_PATHS. Please take a look!

[RayBB]

Put it on testing and it's working flawlessly.

Great work @Sanket17052006 and @Shikhar-395 !