close
Skip to content

Simple History Log: Use different message if global lockout is triggered#143

Merged
figureone merged 1 commit into
uhm-coe:masterfrom
TuringTux:different-message-for-global-lockout
Mar 6, 2024
Merged

Simple History Log: Use different message if global lockout is triggered#143
figureone merged 1 commit into
uhm-coe:masterfrom
TuringTux:different-message-for-global-lockout

Conversation

@TuringTux
Copy link
Copy Markdown
Contributor

@TuringTux TuringTux commented Mar 4, 2024

Closes #141.

@TuringTux
Copy link
Copy Markdown
Contributor Author

I have not yet provided translations for this, because I can't recall how exactly adding them worked. If requested, I can add them.

@figureone figureone merged commit f2bc1de into uhm-coe:master Mar 6, 2024
@figureone
Copy link
Copy Markdown
Member

Looks great! We're trying to get a new version soon out so this will be bundled in. Cheers!

@figureone
Copy link
Copy Markdown
Member

For translations I have been using Poedit to update the translation files (looks like my copy is crashing on me so I'll have to work on that). Don't worry about that unless you want to go down the rabbit hole :)

@TuringTux
Copy link
Copy Markdown
Contributor Author

Great, thanks! And thanks for updating the translation files for me :)

@TuringTux TuringTux deleted the different-message-for-global-lockout branch March 6, 2024 08:58
@figureone
Copy link
Copy Markdown
Member

Added new translatable string here: 264df41

And for the es and fr translations: 90eef8e
@julienlusson has provided excellent French translations in the past so let us know if you have time to update this one!

Thanks all, cheers

@julienlusson
Copy link
Copy Markdown
Contributor

@figureone Thanks for the notification, update done!

@figureone
Copy link
Copy Markdown
Member

You're the best @julienlusson thanks!
#145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust message logged to Simple History about global lockout

3 participants